Issue 4179001: [cros] Fix UI issues on SignIn pod.

Issue 4179001: [cros] Fix UI issues on SignIn pod. (Closed)

Created:
10 years, 1 month ago by Nikita (slow)

Modified:
9 years, 7 months ago

Reviewers:
whywhat

CC:
chromium-reviews, nkostylev+cc_chromium.org, davemoore+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

[cros] Fix UI issues on SignIn pod/user pod. 7. Textfield - focus border issue 9. Textfield - font size 11. Sign in - h padding 13,14 Link text & color. Button minimal width - 90px. BUG=chromium-os:8101 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64225

Patch Set 1 #

Patch Set 2 : link color & textfield font size #

Patch Set 3 : button min width, layout fix #

Patch Set 4 : remove test code #

Total comments: 8

Patch Set 5 : merge & address comments #

Patch Set 6 : fix build #

Patch Set 7 : fix build for real #

Patch Set 8 : merge #

Created: 10 years, 1 month ago

	Unified diffs	Side-by-side diffs	Stats (+76 lines, -16 lines)
M	chrome/app/generated_resources.grd	View	1 chunk	+1 line, -1 line	0 comments
M	chrome/browser/chromeos/login/existing_user_view.cc	View	2 chunks	+2 lines, -0 lines	0 comments
M	chrome/browser/chromeos/login/guest_user_view.cc	View	3 chunks	+6 lines, -2 lines	0 comments
M	chrome/browser/chromeos/login/helper.h	View	4 chunks	+14 lines, -0 lines	0 comments
M	chrome/browser/chromeos/login/helper.cc	View	3 chunks	+16 lines, -1 line	0 comments
M	chrome/browser/chromeos/login/login_screen.cc	View	1 chunk	+9 lines, -1 line	0 comments
M	chrome/browser/chromeos/login/message_bubble.cc	View	2 chunks	+3 lines, -0 lines	0 comments
M	chrome/browser/chromeos/login/network_selection_view.cc	View	2 chunks	+3 lines, -3 lines	0 comments
M	chrome/browser/chromeos/login/new_user_view.cc	View	7 chunks	+18 lines, -3 lines	0 comments
M	chrome/browser/chromeos/login/user_controller.cc	View	2 chunks	+3 lines, -2 lines	0 comments
M	chrome/browser/chromeos/login/user_image_view.cc	View	1 chunk	+0 lines, -2 lines	0 comments
M	views/controls/link.cc	View	1 chunk	+1 line, -1 line	0 comments

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

whywhat

LGTM with a few nits http://codereview.chromium.org/4179001/diff/8001/9001 File chrome/app/generated_resources.grd (right): http://codereview.chromium.org/4179001/diff/8001/9001#newcode8977 chrome/app/generated_resources.grd:8977: Skip sign-in and browse ...

10 years, 1 month ago (2010-10-27 12:29:05 UTC) #2

Nikita (slow)

10 years, 1 month ago (2010-10-27 12:50:48 UTC) #3

http://codereview.chromium.org/4179001/diff/8001/9001
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/4179001/diff/8001/9001#newcode8977
chrome/app/generated_resources.grd:8977: Skip sign-in and browse as Guest
On 2010/10/27 12:29:05, whywhat wrote:
> "and enter as guest" or "and enter Guest mode" would be more consistent with
new
> Enter/Exit terminology around Guest mode :)

I'll update this separately if we decide to.

http://codereview.chromium.org/4179001/diff/8001/9008
File chrome/browser/chromeos/login/new_user_view.cc (right):

http://codereview.chromium.org/4179001/diff/8001/9008#newcode216
chrome/browser/chromeos/login/new_user_view.cc:216:
sign_in_button_->set_font(sign_in_button_->font().DeriveFont(2));
On 2010/10/27 12:29:05, whywhat wrote:
> view->set_font(view->font().DeriveFont(2)) could be put into a method like
> CorrectFontSize() maybe into login_helper.h/cc and used in all the code. 2
could
> be a named constant there.

Done.

http://codereview.chromium.org/4179001/diff/8001/9008#newcode392
chrome/browser/chromeos/login/new_user_view.cc:392:
std::max(login::kButtonMinWidth,
On 2010/10/27 12:29:05, whywhat wrote:
> Maybe assign this expression to sign_in_button_width and use that?

Done.

http://codereview.chromium.org/4179001/diff/8001/9009
File chrome/browser/chromeos/login/user_controller.cc (right):

http://codereview.chromium.org/4179001/diff/8001/9009#newcode368
chrome/browser/chromeos/login/user_controller.cc:368: int width =
kUserImageSize;
On 2010/10/27 12:29:05, whywhat wrote:
> why this change?

I'll increase width for new_user_view in the following CL.

Expand Messages | Collapse Messages