Add basic sqlite error handling to the new sqlite handlers...

Add basic sqlite error handling to the new sqlite handlers

This part is just the plumbing of the error detection and notification.

BUG=none
TEST=none



Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27268

[cpu_(ooo_6.6-7.5), 2009-09-23 17:19:42]

Not ready for review yet (it needs unitests) but if you see something very wrong
about it let me know.

[brettw, 2009-09-23 17:26:56]

Seems fine so far.

http://codereview.chromium.org/223003/diff/3001/3002
File app/sql/connection.cc (right):

http://codereview.chromium.org/223003/diff/3001/3002#newcode317
Line 317: if (error_delegate_.get()) {
I'd skip the {} here since the rest of the file doesn't use it.

[cpu_(ooo_6.6-7.5), 2009-09-25 20:10:48]

Ok, it is ready for review.

I also added the clear bindings thingy we discussed.

[brettw, 2009-09-25 20:46:42]

LGTM with some style nits.

http://codereview.chromium.org/223003/diff/4001/5002
File app/sql/connection.h (right):

http://codereview.chromium.org/223003/diff/4001/5002#newcode73
Line 73: // false as while the actual error code and causing statement are
delivered
delete "as"

http://codereview.chromium.org/223003/diff/4001/5005
File app/sql/statement.h (right):

http://codereview.chromium.org/223003/diff/4001/5005#newcode118
Line 118: // Returns the original text of sql statement. Do not keep a pointer
to it.
Can you put a blank line after "Diagnostics" to match the rest of the file?

http://codereview.chromium.org/223003/diff/4001/5005#newcode119
Line 119: const char * GetSQLStatement();
Delete the space before the *

http://codereview.chromium.org/223003/diff/4001/5004
File app/sql/statement_unittest.cc (right):

http://codereview.chromium.org/223003/diff/4001/5004#newcode4
Line 4: #include <string>
Put a blank line above this.

http://codereview.chromium.org/223003/diff/4001/5004#newcode55
Line 55: // if any error happened the original sql statement can be found in
Capitalize "if"

[cpu_(ooo_6.6-7.5), 2009-09-25 21:42:52]

thanks! all taken care of. I'll commit when the weather permits.