Add basic sqlite error handling to the new sqlite handlers...

app/sql/statement.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "app/sql/statement.h"
 
 #include "base/logging.h"
 #include "third_party/sqlite/preprocessed/sqlite3.h"
 
 namespace sql {
@@ skipping 28 matching lines @@
   return CheckError(sqlite3_step(ref_->stmt())) == SQLITE_DONE;
 }
 
 bool Statement::Step() {
   if (!is_valid())
     return false;
   return CheckError(sqlite3_step(ref_->stmt())) == SQLITE_ROW;
 }
 
 void Statement::Reset() {
-  if (is_valid())
-    CheckError(sqlite3_reset(ref_->stmt()));
+  if (is_valid()) {
+    // We don't call CheckError() here because sqlite3_reset() returns
+    // the last error that Step() caused thereby generating a second
+    // spurious error callback.
+    sqlite3_clear_bindings(ref_->stmt());
+    sqlite3_reset(ref_->stmt());
+  }
   succeeded_ = false;
 }
 
 bool Statement::Succeeded() const {
   if (!is_valid())
     return false;
   return succeeded_;
 }
 
 bool Statement::BindNull(int col) {
   if (is_valid()) {
     int err = CheckError(sqlite3_bind_null(ref_->stmt(), col + 1));
-    DCHECK(err == SQLITE_OK) << ref_->connection()->GetErrorMessage();
     return err == SQLITE_OK;
   }
   return false;
 }
 
 bool Statement::BindInt(int col, int val) {
   if (is_valid()) {
     int err = CheckError(sqlite3_bind_int(ref_->stmt(), col + 1, val));
-    DCHECK(err == SQLITE_OK) << ref_->connection()->GetErrorMessage();
     return err == SQLITE_OK;
   }
   return false;
 }
 
 bool Statement::BindInt64(int col, int64 val) {
   if (is_valid()) {
     int err = CheckError(sqlite3_bind_int64(ref_->stmt(), col + 1, val));
-    DCHECK(err == SQLITE_OK) << ref_->connection()->GetErrorMessage();
     return err == SQLITE_OK;
   }
   return false;
 }
 
 bool Statement::BindDouble(int col, double val) {
   if (is_valid()) {
     int err = CheckError(sqlite3_bind_double(ref_->stmt(), col + 1, val));
-    DCHECK(err == SQLITE_OK) << ref_->connection()->GetErrorMessage();
     return err == SQLITE_OK;
   }
   return false;
 }
 
 bool Statement::BindCString(int col, const char* val) {
   if (is_valid()) {
     int err = CheckError(sqlite3_bind_text(ref_->stmt(), col + 1, val, -1,
                          SQLITE_TRANSIENT));
-    DCHECK(err == SQLITE_OK) << ref_->connection()->GetErrorMessage();
     return err == SQLITE_OK;
   }
   return false;
 }
 
 bool Statement::BindString(int col, const std::string& val) {
   if (is_valid()) {
     int err = CheckError(sqlite3_bind_text(ref_->stmt(), col + 1, val.data(),
                                            val.size(), SQLITE_TRANSIENT));
-    DCHECK(err == SQLITE_OK) << ref_->connection()->GetErrorMessage();
     return err == SQLITE_OK;
   }
   return false;
 }
 
 bool Statement::BindBlob(int col, const void* val, int val_len) {
   if (is_valid()) {
     int err = CheckError(sqlite3_bind_blob(ref_->stmt(), col + 1,
                          val, val_len, SQLITE_TRANSIENT));
-    DCHECK(err == SQLITE_OK) << ref_->connection()->GetErrorMessage();
     return err == SQLITE_OK;
   }
   return false;
 }
 
 int Statement::ColumnCount() const {
   if (!is_valid()) {
     NOTREACHED();
     return 0;
   }
@@ skipping 70 matching lines @@
     memcpy(&(*val)[0], data, len);
   }
 }
 
 void Statement::ColumnBlobAsVector(
     int col,
     std::vector<unsigned char>* val) const {
   ColumnBlobAsVector(col, reinterpret_cast< std::vector<char>* >(val));
 }
 
+const char* Statement::GetSQLStatement() {
+  return sqlite3_sql(ref_->stmt());
+}
+
 int Statement::CheckError(int err) {
+  // Please don't add DCHECKs here, OnSqliteError() already has them.
   succeeded_ = (err == SQLITE_OK || err == SQLITE_ROW || err == SQLITE_DONE);
-
-  // TODO(brettw) enhance this to process the error.
+  if (!succeeded_ && is_valid())
+    return ref_->connection()->OnSqliteError(err, this);
   return err;
 }
 
 }  // namespace sql