Issue 2226003: ARM: Add Ldrd/Strd to the macro assembler...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2226003: ARM: Add Ldrd/Strd to the macro assembler... (Closed)

Created:
10 years, 7 months ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

ARM: Add Ldrd/Strd to the macro assembler The macro assembler now checks for ARMv7 support and generates instructions for Ldrd/Strd accordingly. INstructions ldrd/strd in the assembler requires ARMv7 support enabled. This removes the a check for CAN_USE_ARMV7_INSTRUCTIONS making the ARMv7 support in the simulator fully controled by the --enable-armv7 flag. Committed: http://code.google.com/p/v8/source/detail?r=4726

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+71 lines, -35 lines)			Patch
M	src/arm/assembler-arm.cc	View		1 chunk	+4 lines, -25 lines	0 comments	Download
M	src/arm/codegen-arm.cc	View		8 chunks	+9 lines, -9 lines	0 comments	Download
M	src/arm/full-codegen-arm.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/arm/macro-assembler-arm.h	View		1 chunk	+12 lines, -0 lines	0 comments	Download
M	src/arm/macro-assembler-arm.cc	View	1	1 chunk	+45 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

LGTM http://codereview.chromium.org/2226003/diff/1/5 File src/arm/macro-assembler-arm.cc (right): http://codereview.chromium.org/2226003/diff/1/5#newcode400 src/arm/macro-assembler-arm.cc:400: too many blank lines here

10 years, 7 months ago (2010-05-26 11:15:19 UTC) #2

Søren Thygesen Gjesse

10 years, 7 months ago (2010-05-26 11:19:30 UTC) #3

http://codereview.chromium.org/2226003/diff/1/5
File src/arm/macro-assembler-arm.cc (right):

http://codereview.chromium.org/2226003/diff/1/5#newcode400
src/arm/macro-assembler-arm.cc:400: 
On 2010/05/26 11:15:20, Erik Corry wrote:
> too many blank lines here

Done.

Expand Messages | Collapse Messages