Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 220005: Update V8 to version 1.3.13.2.... (Closed)

Created:
11 years, 3 months ago by Mads Ager (chromium)
Modified:
9 years, 7 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Update V8 to version 1.3.13.2. Only one change to the V8 gyp file to fix problem for gcc 4.4. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26918

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (chromium)
11 years, 3 months ago (2009-09-23 14:41:43 UTC) #1
Mark Mentovai
11 years, 3 months ago (2009-09-23 14:44:50 UTC) #2
LGTM

On Wed, Sep 23, 2009 at 10:41 AM,  <ager@chromium.org> wrote:
> Reviewers: Mark Mentovai,
>
> Description:
> Update V8 to version 1.3.13.2.
>
> Only one change to the V8 gyp file to fix problem for gcc 4.4.
>
> BUG=3Dnone
> TEST=3Dnone
>
> Please review this at http://codereview.chromium.org/220005
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
> =A0M =A0 =A0 DEPS
>
>
> Index: DEPS
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- DEPS =A0 =A0 =A0 =A0(revision 26917)
> +++ DEPS =A0 =A0 =A0 =A0(working copy)
> @@ -37,7 +37,7 @@
> =A0 =A0 "http://gyp.googlecode.com/svn/trunk@664",
>
> =A0 "src/v8":
> - =A0 =A0"http://v8.googlecode.com/svn/trunk@2962",
> + =A0 =A0"http://v8.googlecode.com/svn/trunk@2966",
>
> =A0 "src/native_client":
> =A0 =A0 "http://nativeclient.googlecode.com/svn/trunk/src/native_client@7=
30",
>
>
>

Powered by Google App Engine
This is Rietveld 408576698