Issue 218037: GTK: Fix overflow chevron for RTL locales.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 218037: GTK: Fix overflow chevron for RTL locales. (Closed)

Created:
11 years, 3 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
Evan Martin

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

GTK: Fix overflow chevron for RTL locales. BUG=22872 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27165

Patch Set 1 #

Total comments: 2

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -4 lines)			Patch
	M	chrome/browser/gtk/bookmark_bar_gtk.cc	View		1 chunk	+11 lines, -4 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

LGTM if it works http://codereview.chromium.org/218037/diff/1/2 File chrome/browser/gtk/bookmark_bar_gtk.cc (right): http://codereview.chromium.org/218037/diff/1/2#newcode471 Line 471: bookmark_toolbar_.get()->allocation.x - extra_space); It's ...

11 years, 3 months ago (2009-09-24 21:12:05 UTC) #2

Evan Stade

11 years, 3 months ago (2009-09-24 21:15:41 UTC) #3

http://codereview.chromium.org/218037/diff/1/2
File chrome/browser/gtk/bookmark_bar_gtk.cc (right):

http://codereview.chromium.org/218037/diff/1/2#newcode471
Line 471: bookmark_toolbar_.get()->allocation.x - extra_space);
On 2009/09/24 21:12:05, Evan Martin wrote:
> It's confusing to me what origins these allocation.x values are relative to. 
:(

they are relative to the parent GdkWindow that they both share. It was in error
that I didn't take into account the toolbar's allocation.x before, but it didn't
matter because it's always (?) 0 for LTR since the toolbar is the first thing on
the bookmark bar.

Expand Messages | Collapse Messages