GTK: Fix overflow chevron for RTL locales.

chrome/browser/gtk/bookmark_bar_gtk.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/gtk/bookmark_bar_gtk.h"
 
 #include <vector>
 
 #include "app/gfx/text_elider.h"
 #include "app/gtk_dnd_util.h"
@@ skipping 448 matching lines @@
 }
 
 int BookmarkBarGtk::GetFirstHiddenBookmark(
     int extra_space, std::vector<GtkWidget*>* showing_folders) {
   int rv = 0;
   bool overflow = false;
   GList* toolbar_items =
       gtk_container_get_children(GTK_CONTAINER(bookmark_toolbar_.get()));
   for (GList* iter = toolbar_items; iter; iter = g_list_next(iter)) {
     GtkWidget* tool_item = reinterpret_cast<GtkWidget*>(iter->data);
-    if (tool_item->allocation.x + tool_item->allocation.width >
-        bookmark_toolbar_.get()->allocation.width + extra_space) {
-      overflow = true;
+    if (gtk_widget_get_direction(tool_item) == GTK_TEXT_DIR_RTL) {
+      overflow = (tool_item->allocation.x <
+                  bookmark_toolbar_.get()->allocation.x - extra_space);

[Evan Martin, 2009/09/24 21:12:05]

It's confusing to me what origins these allocation.x values are relative to.  :(

[Evan Stade, 2009/09/24 21:15:42]

they are relative to the parent GdkWindow that they both share. It was in error
that I didn't take into account the toolbar's allocation.x before, but it didn't
matter because it's always (?) 0 for LTR since the toolbar is the first thing on
the bookmark bar.

+    } else {
+      overflow =
+          (tool_item->allocation.x + tool_item->allocation.width >
+           bookmark_toolbar_.get()->allocation.width +
+           bookmark_toolbar_.get()->allocation.x + extra_space);
+    }
+    if (overflow)
       break;
-    }
+
     if (showing_folders &&
         model_->GetBookmarkBarNode()->GetChild(rv)->is_folder()) {
       showing_folders->push_back(gtk_bin_get_child(GTK_BIN(tool_item)));
     }
     rv++;
   }
 
   g_list_free(toolbar_items);
 
   if (!overflow)
@@ skipping 552 matching lines @@
       break;
     }
   }
   DCHECK_NE(button_idx, -1);
 
   // Find the GtkWidget* for the actual target button.
   int shift = dir == GTK_MENU_DIR_PARENT ? -1 : 1;
   button_idx = (button_idx + shift + folder_list.size()) % folder_list.size();
   PopupForButton(folder_list[button_idx]);
 }