[Mac] Support option-return to open in new foreground tab....

[Mac] Support option-return to open in new foreground tab.

BUG=http://crbug.com/22882
TEST=Type something into the omnibox.  Option-return should open it in a new foreground tab.
TEST=After using Option-return to open something in a new foreground tab, switch back to the original tab and verify that the url in the omnibox has reverted to the original page's url.
TEST=Option-leftclick on a link in a webpage should still prompt you to "save as."

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27127

[Peter Kasting, 2009-09-24 18:32:22]

BTW, one test you should do: After doing option-enter in Tab A (to create Tab
B), switch back to Tab A.  The omnibox should have been reset to the page's URL.
 If it isn't, you should fix it.  The Windows code might give you an idea (I
believe we explictly ResetAll() if the disposition is not NEW_BACKGROUND_TAB).

[Peter Kasting, 2009-09-24 18:35:11]

This approach is wrong, see comments on the bug.

[rohitrao (ping after 24h), 2009-09-24 18:35:21]

Looks like we pass.  I've added another TEST= line, in case QA actually looks at
those.

On 2009/09/24 18:32:22, Peter Kasting wrote:
> BTW, one test you should do: After doing option-enter in Tab A (to create Tab
> B), switch back to Tab A.  The omnibox should have been reset to the page's
URL.
>  If it isn't, you should fix it.  The Windows code might give you an idea (I
> believe we explictly ResetAll() if the disposition is not NEW_BACKGROUND_TAB).

[rohitrao (ping after 24h), 2009-09-24 18:48:58]

Changed this behavior to apply only in the omnibox.  Verified that option-click
in a webpage still prompts you to save as.

[Peter Kasting, 2009-09-24 19:16:02]

On 2009/09/24 18:48:58, rohitrao wrote:
> Changed this behavior to apply only in the omnibox.  Verified that
option-click
> in a webpage still prompts you to save as.

Rad, thanks!

[Scott Hess - ex-Googler, 2009-09-24 20:35:47]

LGTM.  A one-line code change which incidentally allows us to remove a TODO.  So
awesome.