Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/autocomplete/autocomplete_edit_view_mac.mm

Issue 218032: [Mac] Support option-return to open in new foreground tab.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
===================================================================
--- chrome/browser/autocomplete/autocomplete_edit_view_mac.mm (revision 27064)
+++ chrome/browser/autocomplete/autocomplete_edit_view_mac.mm (working copy)
@@ -804,9 +804,9 @@
return YES;
}
- // TODO(shess): Option-return, would normally insert a literal
- // newline. Consider combining with -insertNewline:.
+ // Option-Return
if (cmd == @selector(insertNewlineIgnoringFieldEditor:)) {
+ edit_view_->AcceptInput(NEW_FOREGROUND_TAB, false);
return YES;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698