gclient_scm: fix one more case where revision stores an int

gclient_scm: fix one more case where revision stores an int

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27077

[Marc-Antoine Ruel (Google), 2009-09-24 10:38:49]

lgtm, but I still don't much the value of parsing svn revision as string,
they will never be a hash...

On Sep 23, 2009 11:38 PM, <msb@chromium.org> wrote:

Reviewers: Marc-Antoine Ruel,

Description:
gclient_scm: fix one more case where revision stores an int

Please review this at http://codereview.chromium.org/218016

Affected files:
 M gclient_scm.py


Index: gclient_scm.py
diff --git a/gclient_scm.py b/gclient_scm.py
index
df76188bf1e16cc6132fc0c15f563716d1abc748..b9ede9b96e11bbd7f51e85d5a69cf5bb5dd2b5e3
100644
--- a/gclient_scm.py
+++ b/gclient_scm.py
@@ -163,7 +163,7 @@ class SVNWrapper(SCMWrapper):
      # Retrieve the current HEAD version because svn is slow at null
updates.
      if not revision:
        from_info_live = CaptureSVNInfo(from_info['URL'], '.')
-        revision = from_info_live['Revision']
+        revision = str(from_info_live['Revision'])
        rev_str = ' at %s' % revision

    if from_info['URL'] != components[0]:

[msb, 2009-09-24 16:44:41]

Marc-Antoine Ruel (maruel@google.com) wrote:
> lgtm, but I still don't much the value of parsing svn revision as string,
> they will never be a hash...
> 

The problem is that the git revision is a SHA1 so it can't be stored as an int.
Sinc the SCMWrapper interface is common, revision needs to be stored in a data
type that works for both SVN and git.

On second thought, it looks like I could have stored the SHA1s as number.
It looks like python support arbitrary precision arithmetic:

>>> x = 0xc1675e27e6503ae9ca8f411317b690d37e334ff1
>>> x
1104140397656478595422181275396024098367401578481L
>>> print "0x%x" % x
0xc1675e27e6503ae9ca8f411317b690d37e334ff1
>>> print "%d" % x
1104140397656478595422181275396024098367401578481
>>> x > 1
True
>>> x + 1
1104140397656478595422181275396024098367401578482L

I could revert all the str changes but I see an interesting benefit to using
strings. The revision can now be a tag:

git://foo@stable

> On Sep 23, 2009 11:38 PM, <msb@chromium.org> wrote:
> 
> Reviewers: Marc-Antoine Ruel,
> 
> Description:
> gclient_scm: fix one more case where revision stores an int
> 
> Please review this at http://codereview.chromium.org/218016
> 
> Affected files:
>  M gclient_scm.py
> 
> 
> Index: gclient_scm.py
> diff --git a/gclient_scm.py b/gclient_scm.py
> index
>
df76188bf1e16cc6132fc0c15f563716d1abc748..b9ede9b96e11bbd7f51e85d5a69cf5bb5dd2b5e3
> 100644
> --- a/gclient_scm.py
> +++ b/gclient_scm.py
> @@ -163,7 +163,7 @@ class SVNWrapper(SCMWrapper):
>       # Retrieve the current HEAD version because svn is slow at null
> updates.
>       if not revision:
>         from_info_live = CaptureSVNInfo(from_info['URL'], '.')
> -        revision = from_info_live['Revision']
> +        revision = str(from_info_live['Revision'])
>         rev_str = ' at %s' % revision
> 
>     if from_info['URL'] != components[0]:

[M-A Ruel, 2009-09-24 17:00:36]

It doesn't matter what git uses. At the SCMWrapper.update() level, when
SCMWrapper == svn, revision MUST be a int _anyway_. That's why I'm saying the
string conversions in this functions are unnecessary.