Issue 217008: Update the TabContents::SavePage parameter to take FilePath instead of wstrin...

Issue 217008: Update the TabContents::SavePage parameter to take FilePath instead of wstrin... (Closed)

Created:
11 years, 3 months ago by tfarina (gmail-do not use)

Modified:
9 years, 7 months ago

Reviewers:
Robert Sesek, Paweł Hajdan Jr.

CC:
chromium-reviews_googlegroups.com, Paul Godavari, brettw, Ben Goodger (Google)

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

Update the TabContents::SavePage parameter to take FilePath instead of wstring to avoid conversions "To and From wstring". BUG=None TEST=run unit_tests.exe Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27331

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : ToT #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -27 lines)			Patch
M	chrome/browser/automation/automation_provider.h	View	2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/automation/automation_provider.cc	View	2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/browser_encoding_uitest.cc	View	2	2 chunks	+2 lines, -4 lines	0 comments	Download
M	chrome/browser/download/save_page_browsertest.cc	View	1 2	3 chunks	+3 lines, -6 lines	0 comments	Download
M	chrome/browser/tab_contents/tab_contents.h	View	1 2	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/tab_contents/tab_contents.cc	View	1 2	1 chunk	+2 lines, -5 lines	0 comments	Download
M	chrome/test/automation/automation_messages_internal.h	View	2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/test/automation/tab_proxy.h	View	2	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/test/automation/tab_proxy.cc	View	2	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

tfarina (gmail-do not use)

Pawel I forget some things in the patchset 1, I will upload a patchset 2 ...

11 years, 3 months ago (2009-09-22 13:42:04 UTC) #2

tfarina (gmail-do not use)

On 2009/09/22 13:42:04, tfarina wrote: > Pawel I forget some things in the patchset 1, ...

11 years, 3 months ago (2009-09-22 13:43:44 UTC) #3

Paweł Hajdan Jr.

LGTM, thanks. I'm going to handle landing this.

11 years, 3 months ago (2009-09-22 15:33:23 UTC) #5

tfarina (gmail-do not use)

On 2009/09/22 15:33:23, Paweł Hajdan Jr. wrote: > LGTM, thanks. I'm going to handle landing ...

11 years, 3 months ago (2009-09-24 15:58:33 UTC) #6

tfarina (gmail-do not use)

On 2009/09/24 15:58:33, tfarina wrote: > On 2009/09/22 15:33:23, Paweł Hajdan Jr. wrote: > > ...

11 years, 2 months ago (2009-09-25 23:09:16 UTC) #7

Robert Sesek

11 years, 2 months ago (2009-09-26 22:17:12 UTC) #8

On 2009/09/25 23:09:16, tfarina wrote:
> On 2009/09/24 15:58:33, tfarina wrote:
> > On 2009/09/22 15:33:23, Paweł Hajdan Jr. wrote:
> > > LGTM, thanks. I'm going to handle landing this.
> > Hi Pawel, did you land my patch?
> Ping

Passed try bots:

http://build.chromium.org/buildbot/try-server/builders/win/builds/630
http://build.chromium.org/buildbot/try-server/builders/linux/builds/595
http://build.chromium.org/buildbot/try-server/builders/mac/builds/611

I'm landing this for Thiago.

Expand Messages | Collapse Messages