chrome/browser/download/save_page_browsertest.cc - Issue 217008: Update the TabContents::SavePage parameter to take FilePath instead of wstrin...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/save_page_browsertest.cc

Issue 217008: Update the TabContents::SavePage parameter to take FilePath instead of wstrin... (Closed) Base URL: http://src.chromium.org/svn/trunk/src/

Patch Set: ToT Created 11 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/download/save_page_browsertest.cc

===================================================================

--- chrome/browser/download/save_page_browsertest.cc (revision 27329)

+++ chrome/browser/download/save_page_browsertest.cc (working copy)

@@ -88,8 +88,7 @@

FilePath full_file_name = save_dir_.path().Append(file_name);

FilePath dir = save_dir_.path().AppendASCII("a_files");

- ASSERT_TRUE(current_tab->SavePage(full_file_name.ToWStringHack(),

- dir.ToWStringHack(),

+ ASSERT_TRUE(current_tab->SavePage(full_file_name, dir,

SavePackage::SAVE_AS_ONLY_HTML));

SavePageFinishedObserver observer;

@@ -114,8 +113,7 @@

FilePath full_file_name = save_dir_.path().Append(file_name);

FilePath dir = save_dir_.path().AppendASCII("b_files");

- ASSERT_TRUE(current_tab->SavePage(full_file_name.ToWStringHack(),

- dir.ToWStringHack(),

+ ASSERT_TRUE(current_tab->SavePage(full_file_name, dir,

SavePackage::SAVE_AS_COMPLETE_HTML));

SavePageFinishedObserver observer;

@@ -159,8 +157,7 @@

TabContents* current_tab = browser()->GetSelectedTabContents();

ASSERT_TRUE(current_tab);

- ASSERT_TRUE(current_tab->SavePage(full_file_name.ToWStringHack(),

- dir.ToWStringHack(),

+ ASSERT_TRUE(current_tab->SavePage(full_file_name, dir,

SavePackage::SAVE_AS_COMPLETE_HTML));

SavePageFinishedObserver observer;

« no previous file with comments | « chrome/browser/browser_encoding_uitest.cc ('k') | chrome/browser/tab_contents/tab_contents.h » ('j') | no next file with comments »