Added support for registering additional shared memory objects (textures and ...

Added support for registering additional shared memory objects (textures and buffers etc) with the CommandBuffer.
TEST=none
BUG=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26857

[Ken Russell (Google), 2009-09-22 00:28:57]

http://codereview.chromium.org/216043/diff/1/3
File o3d/gpu_plugin/command_buffer.cc (right):

http://codereview.chromium.org/216043/diff/1/3#newcode140
Line 140: unused_registered_object_elements_.erase(
I don't think this does what you intend. vector::erase() requires an iterator
between begin() and end(). I think you need to explicitly find the handle and
then erase it.

http://codereview.chromium.org/216043/diff/1/2
File o3d/gpu_plugin/command_buffer_unittest.cc (right):

http://codereview.chromium.org/216043/diff/1/2#newcode199
Line 199: EXPECT_EQ(1, command_buffer_->RegisterObject(window_object_));
I think you should add a test which registers two objects, deregisters 2 and
then 1, and then registers a new one and verifies its handle is 1. If I
understand what's going on in command_buffer.cc then it will catch a bug.

[apatrick, 2009-09-22 20:17:04]

http://codereview.chromium.org/216043/diff/1/3
File o3d/gpu_plugin/command_buffer.cc (right):

http://codereview.chromium.org/216043/diff/1/3#newcode140
Line 140: unused_registered_object_elements_.erase(
There are three forms of std::set::erase. I'm using this one:
size_type erase(const key_type& k)

http://codereview.chromium.org/216043/diff/1/2
File o3d/gpu_plugin/command_buffer_unittest.cc (right):

http://codereview.chromium.org/216043/diff/1/2#newcode199
Line 199: EXPECT_EQ(1, command_buffer_->RegisterObject(window_object_));
Done. Seems to work. Also added a parameter to UnregisterObject. Now the caller
has to demonstrate that it has access to an object before it is allowed to
unregister it. Also added a function (not exposed over NPAPI) that tests can use
to get the object mapped to a handle.

[Ken Russell (Google), 2009-09-22 20:57:08]

On 2009/09/22 20:17:04, apatrick wrote:
> http://codereview.chromium.org/216043/diff/1/3
> File o3d/gpu_plugin/command_buffer.cc (right):
> 
> http://codereview.chromium.org/216043/diff/1/3#newcode140
> Line 140: unused_registered_object_elements_.erase(
> There are three forms of std::set::erase. I'm using this one:
> size_type erase(const key_type& k)

You're right; my mistake. I was looking at the documentation for vector, not
set.

LGTM