gclient_scm: add test for unsupported scm

Use a factory method to abstract SCMWrapper creation.

This method will eventually return the correct subclass of SCMWrapper. Initially, there will only be SVNWrapper.

gclient_scm: add test for unsupported scm

gclient_scm: make SCMWrapper constructor parameters non-optional

gclient_scm: add a checks for unsupported scm and unimplemented method

git_scm: pull out svn code into SVNWrapper

gclient_scm: create a create_scm factory method

TEST=
BUG=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26602

[M-A Ruel, 2009-09-17 20:56:15]

http://codereview.chromium.org/216014/diff/1/3
File gclient_scm.py (right):

http://codereview.chromium.org/216014/diff/1/3#newcode32
Line 32: def create_scm(url, root_dir, relpath, scm_name='svn'):
Functions should be CamelCase too.

[msb, 2009-09-17 21:28:41]

maruel@chromium.org (maruel@chromium.org) wrote:
>
> http://codereview.chromium.org/216014/diff/1/3
> File gclient_scm.py (right):
>
> http://codereview.chromium.org/216014/diff/1/3#newcode32
> Line 32: def create_scm(url, root_dir, relpath, scm_name='svn'):
> Functions should be CamelCase too.
>

What style guide are we using?

I was assuming this one:

http://www.python.org/dev/peps/pep-0008/

> http://codereview.chromium.org/216014

[M-A Ruel, 2009-09-17 22:34:29]

On 2009/09/17 21:28:41, msb_google.com wrote:
> What style guide are we using?
> 
> I was assuming this one:
> 
> http://www.python.org/dev/peps/pep-0008/

Err, this one
http://google-styleguide.googlecode.com/svn/trunk/pyguide.html

[msb, 2009-09-17 22:39:25]

On Thu, Sep 17, 2009 at 3:34 PM,  <maruel@chromium.org> wrote:
> On 2009/09/17 21:28:41, msb_google.com wrote:
>>
>> What style guide are we using?
>
>> I was assuming this one:
>
>> http://www.python.org/dev/peps/pep-0008/
>
> Err, this one
> http://google-styleguide.googlecode.com/svn/trunk/pyguide.html
>

Ah.

But that style guide also uses lower-case with underscore for function names.

Functions  	lower_with_under()  	_lower_with_under()

>
> http://codereview.chromium.org/216014
>

[M-A Ruel, 2009-09-17 22:42:37]

On 2009/09/17 22:39:25, msb_google.com wrote:
> On Thu, Sep 17, 2009 at 3:34 PM,  <mailto:maruel@chromium.org> wrote:
> > On 2009/09/17 21:28:41, http://msb_google.com wrote:
> >>
> >> What style guide are we using?
> >
> >> I was assuming this one:
> >
> >> http://www.python.org/dev/peps/pep-0008/
> >
> > Err, this one
> > http://google-styleguide.googlecode.com/svn/trunk/pyguide.html
> >
> 
> Ah.
> 
> But that style guide also uses lower-case with underscore for function names.
> 
> Functions  	lower_with_under()  	_lower_with_under()

Gosh. All our code is wrong. :)

lgtm

[msb, 2009-09-18 02:00:05]

maruel@chromium.org (maruel@chromium.org) wrote:
> On 2009/09/17 22:39:25, msb_google.com wrote:
>> On Thu, Sep 17, 2009 at 3:34 PM,  <mailto:maruel@chromium.org> wrote:
>> > On 2009/09/17 21:28:41, http://msb_google.com wrote:
>> >>
>> >> What style guide are we using?
>> >
>> >> I was assuming this one:
>> >
>> >> http://www.python.org/dev/peps/pep-0008/
>> >
>> > Err, this one
>> > http://google-styleguide.googlecode.com/svn/trunk/pyguide.html
>> >
>
>> Ah.
>
>> But that style guide also uses lower-case with underscore for function  
>> names.
>
>> Functions  	lower_with_under()  	_lower_with_under()
>
> Gosh. All our code is wrong. :)
>
> lgtm
>

Can you please submit this for me. I don't have permissions.

>
> http://codereview.chromium.org/216014

[M-A Ruel, 2009-09-18 13:13:10]

On 2009/09/18 02:00:05, msb_google.com wrote:
> Can you please submit this for me. I don't have permissions.

Let'll let you the pleasure to check-in yourself. :)