Issue 215056: Remove potential for command-key equivalents to beat the file menu fix-up tim...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 215056: Remove potential for command-key equivalents to beat the file menu fix-up tim... (Closed)

Created:
11 years, 3 months ago by pink (ping after 24hrs)

Modified:
9 years, 7 months ago

Reviewers:
TVL

CC:
chromium-reviews_googlegroups.com, John Grabowski, pam+watch_chromium.org, Ben Goodger (Google)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Remove potential for command-key equivalents to beat the file menu fix-up timer by clearing the command keys for close tab/window before we fire the timer. BUG=16689 TEST=cmd-w closes tabs/windows correctly based on number of tabs in the window and if the window is a browser window. Also comment 16 in the bug. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26862

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -0 lines)			Patch
	M	chrome/browser/app_controller_mac.mm	View	1	3 chunks	+33 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

TVL

LG. Splitting hairs case: what if the use uses some macro util, voice over, etc. ...

11 years, 3 months ago (2009-09-22 20:44:19 UTC) #2

pink (ping after 24hrs)

11 years, 3 months ago (2009-09-22 20:46:32 UTC) #3

VoiceOver wouldn't change the behavior, because you presumably say the
exact command you want. That doesn't change, nor does the ordering in
the menu list. Only the cmd-key is changing, so that's what we need to
clear.

On Tue, Sep 22, 2009 at 4:44 PM,  <thomasvl@chromium.org> wrote:
> LG.
>
> Splitting hairs case: what if the use uses some macro util, voice over, e=
tc.
> to
> fire menu items? =A0Then it's still possible to hit this case by picking =
the
> menu
> items in the race case, do does it make sense to disable them/change the
> selector they send/etc?
>
> http://codereview.chromium.org/215056
>

--=20
Mike Pinkerton
Mac Weenie
pinkerton@google.com

Expand Messages | Collapse Messages