gclient_scm: add test for unsupported scm

gclient_scm: add test for unsupported scm


gclient_scm: use a map for deciding whether or not the scm is supported


gclient_scm: add a checks for unsupported scm and unimplemented method


git_scm: pull out svn code into SVNWrapper


gclient_scm: create a create_scm factory method

Use a factory method to abstract SCMWrapper creation. This method
will eventually return the correct subclass of SCMWrapper. Initially,
there will only be SVNWrapper.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26823

[M-A Ruel, 2009-09-18 21:20:33]

http://codereview.chromium.org/215022/diff/1/3
File gclient_scm.py (right):

http://codereview.chromium.org/215022/diff/1/3#newcode32
Line 32: def create_scm(url=None, root_dir=None, relpath=None, scm_name='svn'):
Naa, I win:
"module_name, package_name, ClassName, MethodName, ExceptionName, FunctionName,
GLOBAL_VAR_NAME, instance_var_name, function_parameter_name, local_var_name. "

see FunctionName.

[msb, 2009-09-18 21:49:08]

maruel@chromium.org (maruel@chromium.org) wrote:
>
> http://codereview.chromium.org/215022/diff/1/3
> File gclient_scm.py (right):
>
> http://codereview.chromium.org/215022/diff/1/3#newcode32
> Line 32: def create_scm(url=None, root_dir=None, relpath=None,
> scm_name='svn'):
> Naa, I win:
> "module_name, package_name, ClassName, MethodName, ExceptionName,
> FunctionName, GLOBAL_VAR_NAME, instance_var_name,
> function_parameter_name, local_var_name. "
>
> see FunctionName.
>

k, I'll convert to FunctionName.

What style guide is this from?

> http://codereview.chromium.org/215022

[msb, 2009-09-18 23:50:23]

Fixed. PTAL.

maruel@chromium.org (maruel@chromium.org) wrote:
>
> http://codereview.chromium.org/215022/diff/1/3
> File gclient_scm.py (right):
>
> http://codereview.chromium.org/215022/diff/1/3#newcode32
> Line 32: def create_scm(url=None, root_dir=None, relpath=None,
> scm_name='svn'):
> Naa, I win:
> "module_name, package_name, ClassName, MethodName, ExceptionName,
> FunctionName, GLOBAL_VAR_NAME, instance_var_name,
> function_parameter_name, local_var_name. "
>
> see FunctionName.
>
> http://codereview.chromium.org/215022

[M-A Ruel, 2009-09-21 00:34:30]

lgtm