The WebPluginImpl::paint function can be invoked when the delegate_ member is...

The WebPluginImpl::paint function can be invoked when the delegate_ member is NULL. This scenario
can happen if a plugin is reinitialized, in which case the plugin instance is torn down and a new one
is initialized. If the second initialization fails, we have a plugin instance in the renderer which has
a NULL delegate_.

Fix is to add a NULL check for the delegate in the paint function.

Fixes http://code.google.com/p/chromium/issues/detail?id=22196

Bug=22196
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26552

[jam, 2009-09-17 23:08:22]

lgtm

why not just an early return?

[ananta, 2009-09-17 23:22:54]

On 2009/09/17 23:08:22, John Abd-El-Malek wrote:
> lgtm
> 
> why not just an early return?
Done.

[darin (slow to review), 2009-09-18 04:32:26]

The scenario that leads to this crash sounds like something we could simulate in
a test, right?

[iyengar, 2009-09-18 04:44:08]

To simulate this in a test, we would need to issue a byte range request from
a plugin in response to which the web serverwould return a HTTP 200
response. This would trigger reinitialization of the plugin which then needs
to fail.

I will try and get to the test case in a subsequent CL..

Thanks
Ananta

On Thu, Sep 17, 2009 at 9:32 PM, <darin@chromium.org> wrote:

> The scenario that leads to this crash sounds like something we could
> simulate in
> a test, right?
>
>
> http://codereview.chromium.org/215018
>