Issue 2145002: Mac: Fix renderer idle cpu usage regression.

Issue 2145002: Mac: Fix renderer idle cpu usage regression. (Closed)

Created:
10 years, 7 months ago by Nico

Modified:
9 years, 7 months ago

Reviewers:
Aaron Boodman, pink (ping after 24hrs), Jay Civelli, Matt Perry

CC:
chromium-reviews, Jay Civelli, Aaron Boodman

Visibility:
Public.

Description

Mac: Fix renderer idle cpu usage regression. Since polling is required only for the preferred height and mac only needs preferred width, add a flag that specifies if the client is interested in width and/or height. This is a band-aid, the Real Fix is tracked in 44850. BUG=44494 TEST=Open chrome's task manager. Idle renderer processes should take close to 0 %cpu instead of ~1.5 before. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48056

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : rebase #

Total comments: 2

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -17 lines)			Patch
M	chrome/browser/extensions/extension_host.cc	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/notifications/balloon_host.cc	View	1 2 3	2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/renderer_host/render_view_host.h	View	1 2 3	1 chunk	+1 line, -1 line	2 comments	Download
M	chrome/browser/renderer_host/render_view_host.cc	View	1 2 3	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/tab_contents/tab_contents.cc	View	1 2 3	1 chunk	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/tab_contents/tab_contents_view_mac.mm	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download
M	chrome/common/render_messages.h	View	2 3	1 chunk	+9 lines, -0 lines	0 comments	Download
M	chrome/common/render_messages_internal.h	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/renderer/render_view.h	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/renderer/render_view.cc	View	1 2 3	1 chunk	+12 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

pink (ping after 24hrs)

LGTM but you probably want aa or something to take a look just to be ...

10 years, 7 months ago (2010-05-24 17:05:16 UTC) #2

Jay Civelli

LGTM http://codereview.chromium.org/2145002/diff/7001/8004 File chrome/browser/renderer_host/render_view_host.h (right): http://codereview.chromium.org/2145002/diff/7001/8004#newcode465 chrome/browser/renderer_host/render_view_host.h:465: // changed. Could you add a comment on ...

10 years, 7 months ago (2010-05-24 17:17:56 UTC) #4

Nico

10 years, 7 months ago (2010-05-24 17:25:15 UTC) #5

http://codereview.chromium.org/2145002/diff/7001/8004
File chrome/browser/renderer_host/render_view_host.h (right):

http://codereview.chromium.org/2145002/diff/7001/8004#newcode465
chrome/browser/renderer_host/render_view_host.h:465: // changed.
On 2010/05/24 17:17:56, Jay Civelli wrote:
> Could you add a comment on where these flags are defined?

Done.

Expand Messages | Collapse Messages