Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2672)

Unified Diff: chrome/renderer/render_view.cc

Issue 2145002: Mac: Fix renderer idle cpu usage regression. (Closed)
Patch Set: rebase Created 10 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/render_view.cc
diff --git a/chrome/renderer/render_view.cc b/chrome/renderer/render_view.cc
index e1a0dc360884b5378ef71aa924bc30072fc8e422..832914a42569e54f2e1e9cf8c954580301eca0d8 100644
--- a/chrome/renderer/render_view.cc
+++ b/chrome/renderer/render_view.cc
@@ -3875,13 +3875,21 @@ void RenderView::OnEnableViewSourceMode() {
main_frame->enableViewSourceMode(true);
}
-void RenderView::OnEnablePreferredSizeChangedMode() {
+void RenderView::OnEnablePreferredSizeChangedMode(int flags) {
+ DCHECK(flags != kPreferredSizeNothing);
if (send_preferred_size_changes_)
return;
-
send_preferred_size_changes_ = true;
- preferred_size_change_timer_.Start(TimeDelta::FromMilliseconds(10), this,
- &RenderView::CheckPreferredSize);
+
+ // WebKit doesn't send a notification of the effective height of the page
+ // changes, so poll for it.
+ // TODO: Add a notification for this to WebKit, remove polling. After that's
+ // done, rename kPreferredSizeHeightThisIsSlow to kPreferredSizeHeight.
+ // http://crbug.com/44850
+ if (flags & kPreferredSizeHeightThisIsSlow) {
+ preferred_size_change_timer_.Start(TimeDelta::FromMilliseconds(10), this,
+ &RenderView::CheckPreferredSize);
+ }
}
void RenderView::OnDisableScrollbarsForSmallWindows(
« chrome/browser/renderer_host/render_view_host.h ('K') | « chrome/renderer/render_view.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698