Issue 214018: Look for the WMP plugin in the directory that it's left in if Firefox isn't i...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 214018: Look for the WMP plugin in the directory that it's left in if Firefox isn't i... (Closed)

Created:
11 years, 3 months ago by jam

Modified:
9 years, 7 months ago

Reviewers:
ananta

CC:
chromium-reviews_googlegroups.com, darin (slow to review)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Look for the WMP plugin in the directory that it's left in if Firefox isn't installed. BUG=22077 TEST=on a machine without Firefox, install the WMP NPAPI plugin and ensure that Chrome finds it Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26594

Patch Set 1 : '' #

Total comments: 1

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -0 lines)			Patch
	M	webkit/glue/plugins/plugin_list_win.cc	View		2 chunks	+22 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ananta

LGTM. Please verify whether this works correctly on Vista. http://codereview.chromium.org/214018/diff/1001/1002 File webkit/glue/plugins/plugin_list_win.cc (right): http://codereview.chromium.org/214018/diff/1001/1002#newcode162 Line ...

11 years, 3 months ago (2009-09-18 17:43:57 UTC) #2

jam

11 years, 3 months ago (2009-09-18 17:54:32 UTC) #3

On Fri, Sep 18, 2009 at 10:43 AM, <ananta@chromium.org> wrote:

> LGTM. Please verify whether this works correctly on Vista.
>

i had tested on xp/vista/7

>
>
>
>
> http://codereview.chromium.org/214018/diff/1001/1002
> File webkit/glue/plugins/plugin_list_win.cc (right):
>
> http://codereview.chromium.org/214018/diff/1001/1002#newcode162
> Line 162: wchar_t *next_drive = strings.get();
> wchar_t* ?

done

>
>
> http://codereview.chromium.org/214018
>

Expand Messages | Collapse Messages