Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 214017: gclient_scm: add test to catch bug fixed by r208010 (Closed)

Created:
11 years, 3 months ago by Mandeep Singh Baines
Modified:
9 years, 7 months ago
Reviewers:
bradnelson, M-A Ruel
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

gclient_scm: add test to catch bug fixed by r208010 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26577

Patch Set 1 #

Total comments: 1

Patch Set 2 : add bug explanation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M tests/gclient_test.py View 1 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Mandeep Singh Baines
11 years, 3 months ago (2009-09-18 02:28:55 UTC) #1
M-A Ruel
http://codereview.chromium.org/214017/diff/1/2 File tests/gclient_test.py (right): http://codereview.chromium.org/214017/diff/1/2#newcode1142 Line 1142: # TODO(msb): fix bug and enable assertion below ...
11 years, 3 months ago (2009-09-18 13:07:23 UTC) #2
msb
maruel@chromium.org (maruel@chromium.org) wrote: > > http://codereview.chromium.org/214017/diff/1/2 > File tests/gclient_test.py (right): > > http://codereview.chromium.org/214017/diff/1/2#newcode1142 > Line ...
11 years, 3 months ago (2009-09-18 16:23:27 UTC) #3
M-A Ruel
11 years, 3 months ago (2009-09-18 16:31:13 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698