AutoFill: Preview form field values when the user changes the AutoFill dropdown

AutoFill: Preview form field values when the user changes the AutoFill dropdown
selection.  Refactor form field enumeration into ForEachMatchingFormField().

BUG=38582
TEST=FormManagerTest.PreviewForm

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48746

[James Hawkins, 2010-05-21 22:25:41]

This is waiting on some WK commits, and there is a known WK bug where the field
that initiates the dropdown (has a cursor in it) is not showing the placeholder
value.

[dhollowa, 2010-05-24 18:07:48]

http://codereview.chromium.org/2138005/diff/1/4
File chrome/renderer/form_manager_unittest.cc (right):

http://codereview.chromium.org/2138005/diff/1/4#newcode481
chrome/renderer/form_manager_unittest.cc:481:
EXPECT_TRUE(firstname.isAutofilled());
Would be nice to exercise the case where |isAutofilled()| returns false.  I.e.
case where the input field is hidden, and the input field has autoComplete="off"
attribute.

http://codereview.chromium.org/2138005/diff/1/5
File chrome/renderer/render_view.cc (right):

http://codereview.chromium.org/2138005/diff/1/5#newcode4991
chrome/renderer/render_view.cc:4991: autofill_query_id_ = query_counter++;
This is not thread-safe, does it need to be?

[James Hawkins, 2010-05-24 21:37:31]

http://codereview.chromium.org/2138005/diff/1/4
File chrome/renderer/form_manager_unittest.cc (right):

http://codereview.chromium.org/2138005/diff/1/4#newcode481
chrome/renderer/form_manager_unittest.cc:481:
EXPECT_TRUE(firstname.isAutofilled());
On 2010/05/24 18:07:48, dhollowa wrote:
> Would be nice to exercise the case where |isAutofilled()| returns false.  I.e.
> case where the input field is hidden, and the input field has
autoComplete="off"
> attribute.

Done.

http://codereview.chromium.org/2138005/diff/1/5
File chrome/renderer/render_view.cc (right):

http://codereview.chromium.org/2138005/diff/1/5#newcode4991
chrome/renderer/render_view.cc:4991: autofill_query_id_ = query_counter++;
On 2010/05/24 18:07:48, dhollowa wrote:
> This is not thread-safe, does it need to be?

No, if we get another AutoFill request, we start the process over.  There are
checks to verify query_id == autofill_query_id_.

[dhollowa, 2010-05-24 22:20:31]

LGTM, pending #if 0 stuff.

http://codereview.chromium.org/2138005/diff/7001/8003
File chrome/renderer/form_manager_unittest.cc (right):

http://codereview.chromium.org/2138005/diff/7001/8003#newcode446
chrome/renderer/form_manager_unittest.cc:446: #if 0
Looks like this got left in by mistake?

[James Hawkins, 2010-05-24 22:32:11]

http://codereview.chromium.org/2138005/diff/7001/8003
File chrome/renderer/form_manager_unittest.cc (right):

http://codereview.chromium.org/2138005/diff/7001/8003#newcode446
chrome/renderer/form_manager_unittest.cc:446: #if 0
On 2010/05/24 22:20:32, dhollowa wrote:
> Looks like this got left in by mistake?

Yeppers.

[dhollowa, 2010-06-02 00:50:46]

On 2010/05/24 22:32:11, James Hawkins wrote:
> http://codereview.chromium.org/2138005/diff/7001/8003
> File chrome/renderer/form_manager_unittest.cc (right):
> 
> http://codereview.chromium.org/2138005/diff/7001/8003#newcode446
> chrome/renderer/form_manager_unittest.cc:446: #if 0
> On 2010/05/24 22:20:32, dhollowa wrote:
> > Looks like this got left in by mistake?
> 
> Yeppers.

LGTM.