AutoFill: Preview form field values when the user changes the AutoFill dropdown

chrome/renderer/render_view.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/render_view.h"
 
 #include <algorithm>
 #include <string>
 #include <vector>
 
@@ skipping 384 matching lines @@
 #if defined(OS_MACOSX)
       has_document_tag_(false),
 #endif
       document_tag_(0),
       webkit_preferences_(webkit_preferences),
       session_storage_namespace_id_(session_storage_namespace_id),
       ALLOW_THIS_IN_INITIALIZER_LIST(cookie_jar_(this)),
       ALLOW_THIS_IN_INITIALIZER_LIST(translate_helper_(this)),
       cross_origin_access_count_(0),
       same_origin_access_count_(0),
-      ALLOW_THIS_IN_INITIALIZER_LIST(pepper_delegate_(this)) {
+      ALLOW_THIS_IN_INITIALIZER_LIST(pepper_delegate_(this)),
+      autofill_action_(AUTOFILL_NONE) {
   ClearBlockedContentSettings();
 }
 
 RenderView::~RenderView() {
   if (decrement_shared_popup_at_destruction_)
     shared_popup_counter_->data--;
 
   // Dispose of un-disposed image fetchers.
   for (ImageResourceFetcherSet::iterator i = image_fetchers_.begin();
        i != image_fetchers_.end(); ++i) {
@@ skipping 1082 matching lines @@
     int default_suggestion_index) {
   if (webview() && query_id == autofill_query_id_) {
     webview()->applyAutocompleteSuggestions(
         autofill_query_node_, suggestions, default_suggestion_index);
   }
   autofill_query_node_.reset();
 }
 
 void RenderView::OnAutoFillFormDataFilled(int query_id,
                                           const webkit_glue::FormData& form) {
-  if (query_id != autofill_query_id_)
+  if (!webview() || query_id != autofill_query_id_)
     return;
 
-  form_manager_.FillForm(form);
+  DCHECK_NE(AUTOFILL_NONE, autofill_action_);
+
+  if (autofill_action_ == AUTOFILL_FILL)
+    form_manager_.FillForm(form);
+  else if (autofill_action_ == AUTOFILL_PREVIEW)
+    form_manager_.PreviewForm(form);
+
+  autofill_action_ = AUTOFILL_NONE;
 }
 
 void RenderView::OnAllowScriptToClose(bool script_can_close) {
   script_can_close_ = script_can_close;
 }
 
 uint32 RenderView::GetCPBrowsingContext() {
   uint32 context = 0;
   Send(new ViewHostMsg_GetCPBrowsingContext(&context));
   return context;
@@ skipping 501 matching lines @@
 
   Send(new ViewHostMsg_QueryFormFieldAutofill(
       routing_id_, autofill_query_id_, field));
 }
 
 void RenderView::removeAutofillSuggestions(const WebString& name,
                                            const WebString& value) {
   Send(new ViewHostMsg_RemoveAutofillEntry(routing_id_, name, value));
 }
 
-void RenderView::didAcceptAutoFillSuggestion(
-      const WebKit::WebNode& node,
-      const WebKit::WebString& value,
-      const WebKit::WebString& label) {
-  static int query_counter = 0;
-  autofill_query_id_ = query_counter++;
+void RenderView::didAcceptAutoFillSuggestion(const WebKit::WebNode& node,
+                                             const WebKit::WebString& value,
+                                             const WebKit::WebString& label) {
+  QueryAutoFillFormData(node, value, label, AUTOFILL_FILL);
+}
 
+void RenderView::didSelectAutoFillSuggestion(const WebKit::WebNode& node,
+                                             const WebKit::WebString& value,
+                                             const WebKit::WebString& label) {
+  didClearAutoFillSelection(node);
+  QueryAutoFillFormData(node, value, label, AUTOFILL_PREVIEW);
+}
+
+void RenderView::didClearAutoFillSelection(const WebKit::WebNode& node) {
   webkit_glue::FormData form;
-  const WebInputElement element = node.toConst<WebInputElement>();
+  const WebFormControlElement element = node.toConst<WebFormControlElement>();
   if (!form_manager_.FindFormWithFormControlElement(
           element, FormManager::REQUIRE_NONE, &form))
     return;
-
-  Send(new ViewHostMsg_FillAutoFillFormData(
-      routing_id_, autofill_query_id_, form, value, label));
+  form_manager_.ClearPreviewedForm(form);
 }
 
 // WebKit::WebWidgetClient ----------------------------------------------------
 
 // We are supposed to get a single call to Show for a newly created RenderView
 // that was created via RenderView::CreateWebView.  So, we wait until this
 // point to dispatch the ShowView message.
 //
 // This method provides us with the information about how to display the newly
 // created RenderView (i.e., as a constrained popup or as a new tab).
@@ skipping 2979 matching lines @@
 
     if (last_top_level_navigation_page_id_ != page_id_ &&
         // Not interested in reloads.
         type != WebKit::WebNavigationTypeReload &&
         type != WebKit::WebNavigationTypeFormSubmitted) {
       return true;
     }
   }
   return false;
 }
+
+void RenderView::QueryAutoFillFormData(const WebKit::WebNode& node,
+                                       const WebKit::WebString& value,
+                                       const WebKit::WebString& label,
+                                       AutoFillAction action) {
+  static int query_counter = 0;
+  autofill_query_id_ = query_counter++;
+
+  webkit_glue::FormData form;
+  const WebInputElement element = node.toConst<WebInputElement>();
+  if (!form_manager_.FindFormWithFormControlElement(
+          element, FormManager::REQUIRE_NONE, &form))
+    return;
+
+  autofill_action_ = action;
+  Send(new ViewHostMsg_FillAutoFillFormData(
+      routing_id_, autofill_query_id_, form, value, label));
+}