Issue 21338: Fix for Issue 7651 Regression: The position of input method window is not cor...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 21338: Fix for Issue 7651 Regression: The position of input method window is not cor... (Closed)

Created:
11 years, 10 months ago by Hironori Bono

Modified:
9 years, 7 months ago

Reviewers:
jungshik at Google

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix for Issue 7651 Regression: The position of input method window is not correct after scrolling page down. This is caused by my bonehead mistake in fixing Issue 6652 that I forgot calling the FrameView::contentsToWindow() function. (I need to add a unit-test to prevent this regression, though.) BUG=7651 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=9942

Patch Set 1 #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	webkit/glue/webview_impl.cc	View		1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jungshik at Google

11 years, 10 months ago (2009-02-13 23:49:10 UTC) #2

lgtm ! I'm taking the blame, too, for missing it. :-)

Expand Messages | Collapse Messages