webkit/glue/webview_impl.cc - Issue 21338: Fix for Issue 7651 Regression: The position of input method window is not cor...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/glue/webview_impl.cc

Issue 21338: Fix for Issue 7651 Regression: The position of input method window is not cor... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 11 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webkit/glue/webview_impl.cc

===================================================================

--- webkit/glue/webview_impl.cc (revision 9719)

+++ webkit/glue/webview_impl.cc (working copy)

@@ -1183,7 +1183,10 @@

return false;

*enable_ime = node->shouldUseInputMethod() &&

!controller->isInPasswordField();

- const IntRect rect(controller->absoluteCaretBounds());

+ const FrameView* view = node->document()->view();

+ if (!view)

+ return false;

+ const IntRect rect(view->contentsToWindow(controller->absoluteCaretBounds()));

caret_rect->SetRect(rect.x(), rect.y(), rect.width(), rect.height());

return true;

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »