[Mac] Paste in Omnibox needs to initiate field editing correctly.

[Mac] Paste in Omnibox needs to initiate field editing correctly.

We override -paste: to do Chrome-specific stuff.  This circumvents
certain Cocoa-standard setup which happens when user's edit text
views, and elsewhere we depend on that setup being right.  This
changes our code to participate in that setup process.

http://crbug.com/21301
TEST=Copy "raising arizona" to the clipboard.  Put focus in the NTP
(Omnibox field does not have focus ring).  Click in Omnibox field and
paste.  Should now see autocomplete popup.

[Scott Hess - ex-Googler, 2009-09-18 20:24:27]

Indeed, the delegate methods weren't being called in the right places.

[rohitrao (ping after 24h), 2009-09-18 20:38:25]

LGTM

http://codereview.chromium.org/213029/diff/1/2
File chrome/browser/autocomplete/autocomplete_edit_view_mac.mm (right):

http://codereview.chromium.org/213029/diff/1/2#newcode613
Line 613: [editor didChangeText];
So this is what fires off controlTextDidChange?

[Scott Hess - ex-Googler, 2009-09-18 21:20:51]

http://codereview.chromium.org/213029/diff/1/2
File chrome/browser/autocomplete/autocomplete_edit_view_mac.mm (right):

http://codereview.chromium.org/213029/diff/1/2#newcode613
Line 613: [editor didChangeText];
On 2009/09/18 20:38:25, rohitrao wrote:
> So this is what fires off controlTextDidChange?

-didChangeText leads to -controlTextDidChange:, -shouldChangeText* leads to
-controlTextDidBeginEditing:.

The reason for not just pulling those implementations in-line is to handle how
things work if the user types, then pastes, or pastes, then types, or pastes
then pastes.  The later oeprations won't hit -controlTextDidBeginEditing:, but
will hit -controlTextDidChange:.