[Mac] Paste in Omnibox needs to initiate field editing correctly.

chrome/browser/autocomplete/autocomplete_edit_view_mac.mm

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/autocomplete/autocomplete_edit_view_mac.h"
 
 #include <Carbon/Carbon.h>  // kVK_Return
 #include "app/gfx/font.h"
 #include "app/resource_bundle.h"
 #include "base/clipboard.h"
@@ skipping 568 matching lines @@
 }
 
 void AutocompleteEditViewMac::OnPaste() {
   // This code currently expects |field_| to be focussed.
   DCHECK([field_ currentEditor]);
 
   std::wstring text = GetClipboardText(g_browser_process->clipboard());
   if (text.empty()) {
     return;
   }
+  NSString* s = base::SysWideToNSString(text);
 
-  // If this paste will be replacing all the text, record that, so we
-  // can do different behaviors in such a case.
-  const NSRange allRange = NSMakeRange(0, [[field_ stringValue] length]);
+  // -shouldChangeTextInRange:* and -didChangeText are documented in
+  // NSTextView as things you need to do if you write additional
+  // user-initiated editing functions.  They cause the appropriate
+  // delegate methods to be called.
+  // TODO(shess): It would be nice to separate the Cocoa-specific code
+  // from the Chrome-specific code.
+  NSTextView* editor = static_cast<NSTextView*>([field_ currentEditor]);
   const NSRange selectedRange = GetSelectedRange();
-  if (NSEqualRanges(allRange, selectedRange)) {
-    model_->on_paste_replacing_all();
+  if ([editor shouldChangeTextInRange:selectedRange replacementString:s]) {
+    // If this paste will be replacing all the text, record that, so
+    // we can do different behaviors in such a case.
+    const NSRange allRange = NSMakeRange(0, [[field_ stringValue] length]);
+    if (NSEqualRanges(allRange, selectedRange)) {
+      model_->on_paste_replacing_all();
+    }
+
+    // Force a Paste operation to trigger the text_changed code in
+    // OnAfterPossibleChange(), even if identical contents are pasted
+    // into the text box.
+    text_before_change_.clear();
+
+    [editor replaceCharactersInRange:selectedRange withString:s];
+    [editor didChangeText];

[rohitrao (ping after 24h), 2009/09/18 20:38:25]

So this is what fires off controlTextDidChange?

[Scott Hess - ex-Googler, 2009/09/18 21:20:51]

-didChangeText leads to -controlTextDidChange:, -shouldChangeText* leads to
-controlTextDidBeginEditing:.

The reason for not just pulling those implementations in-line is to handle how
things work if the user types, then pastes, or pastes, then types, or pastes
then pastes.  The later oeprations won't hit -controlTextDidBeginEditing:, but
will hit -controlTextDidChange:.

   }
-
-  // Force a Paste operation to trigger the text_changed code in
-  // OnAfterPossibleChange(), even if identical contents are pasted into the
-  // text box.
-  text_before_change_.clear();
-
-  NSString* s = base::SysWideToNSString(text);
-  [[field_ currentEditor] replaceCharactersInRange:selectedRange withString:s];
-
-  OnAfterPossibleChange();
 }
 
 bool AutocompleteEditViewMac::OnTabPressed() {
   if (model_->is_keyword_hint() && !model_->keyword().empty()) {
     model_->AcceptKeyword();
     return true;
   }
   return false;
 }
 
@@ skipping 231 matching lines @@
 // prepended and ".com" appended.  This calls down to
 // AutocompleteEditModel::OnControlKeyChanged() so that it can change
 // the popup to reflect this.  See autocomplete_edit.cc
 // OnControlKeyChanged() and OnAfterPossibleChange().
 - (void)control:(NSControl*)control flagsChanged:(NSEvent*)theEvent {
   bool controlFlag = ([theEvent modifierFlags]&NSControlKeyMask) != 0;
   edit_view_->OnControlKeyChanged(controlFlag);
 }
 
 @end