Issue 213015: Set the parent of BookmarkContextMenu to be the browser window, not

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 213015: Set the parent of BookmarkContextMenu to be the browser window, not (Closed)

Created:
11 years, 3 months ago by tony

Modified:
9 years, 7 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Set the parent of BookmarkContextMenu to be the browser window, not the menu which is just going away. This makes it consistent with the edit dialog that comes up when editing directly on the toolbar. Committed: http://src.chromium.org/viewvc/chrome/26582

Patch Set 1 #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome/browser/gtk/bookmark_menu_controller_gtk.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

So this was causing the menu to pop up in the middle of the screen ...

11 years, 3 months ago (2009-09-17 23:58:41 UTC) #2

tony

On 2009/09/17 23:58:41, Evan Stade wrote: > So this was causing the menu to pop ...

11 years, 3 months ago (2009-09-18 00:00:56 UTC) #3

tony

Oh, for reference, the other noticeable bug is that if you use edit from a ...

11 years, 3 months ago (2009-09-18 00:15:51 UTC) #5

Evan Stade

11 years, 3 months ago (2009-09-18 00:19:48 UTC) #6

yes, that is another "bug" :)

-- Evan Stade



On Thu, Sep 17, 2009 at 5:15 PM,  <tony@chromium.org> wrote:
> Oh, for reference, the other noticeable bug is that if you use edit from a
> bookmark in a menu, you can still interact with the browser window (ie., the
> dialog is not transient).
>
> http://codereview.chromium.org/213015
>

Expand Messages | Collapse Messages