Issue 213009: Fix bug where we fail to install an extension that has an empty

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 213009: Fix bug where we fail to install an extension that has an empty (Closed)

Created:
11 years, 3 months ago by Aaron Boodman

Modified:
9 years, 6 months ago

Reviewers:
rafaelw

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Fix bug where we fail to install an extension that has an empty permissions array in its manifest. This was caused an old attempt to display a warning in this situation, back when we were ambitious. BUG=22157 TEST=Install extension associated with bug. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26534 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26555

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -13 lines)			Patch
M	chrome/common/extensions/extension.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	chrome/common/extensions/extension_constants.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/common/extensions/extension_constants.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/common/extensions/extension_unittest.cc	View	1 chunk	+1 line, -5 lines	0 comments	Download

Total messages: 2 (0 generated)

lgtm