Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5997)

Unified Diff: chrome/common/extensions/extension.cc

Issue 213009: Fix bug where we fail to install an extension that has an empty (Closed)
Patch Set: fix tests Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/common/extensions/extension_constants.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/extension.cc
diff --git a/chrome/common/extensions/extension.cc b/chrome/common/extensions/extension.cc
index 2566d41f2219c8678b893afd7dc52b2d55b8576f..cd2a8c7ae09ab88994ccc1802771c642ccbae6a8 100644
--- a/chrome/common/extensions/extension.cc
+++ b/chrome/common/extensions/extension.cc
@@ -947,11 +947,6 @@ bool Extension::InitFromValue(const DictionaryValue& source, bool require_id,
return false;
}
- if (permissions->GetSize() == 0) {
- ExtensionErrorReporter::GetInstance()->ReportError(
- errors::kInvalidPermissionCountWarning, false);
- }
-
for (size_t i = 0; i < permissions->GetSize(); ++i) {
std::string permission_str;
if (!permissions->GetString(i, &permission_str)) {
« no previous file with comments | « no previous file | chrome/common/extensions/extension_constants.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698