Issue 213002: Fixing errors in gclient on a gclient revert --nohooks on windows....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 213002: Fixing errors in gclient on a gclient revert --nohooks on windows.... (Closed)

Created:
11 years, 3 months ago by bradn

Modified:
9 years, 7 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews_googlegroups.com, Mandeep Singh Baines

Base URL:
svn://chrome-svn/chrome/trunk/tools/depot_tools/

Visibility:
Public.

Description

Fixing errors in gclient on a gclient revert --nohooks on windows. BUG=None TEST=None TBR=maruel Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26425

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	gclient_scm.py	View		2 chunks	+2 lines, -2 lines	0 comments	Download
	M	gclient_utils.py	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

Thanks Mandeep, you now need to write unit test, we can't afford to break gclient ...

11 years, 3 months ago (2009-09-17 00:50:00 UTC) #2

msb

11 years, 3 months ago (2009-09-17 04:29:58 UTC) #3

maruel@chromium.org (maruel@chromium.org) wrote:
> Thanks
>
> Mandeep, you now need to write unit test, we can't afford to break gclient
> further.
>

Sorry about the breakage:(

Unit test review here:

http://codereview.chromium.org/214005

Nearly done with the refactoring. Majority of my future changes will only
add new git functionality so future changes should be less invasive. I will
add a new unit test for any new code which isn't adaquately tested by the
existing unit tests.

> http://codereview.chromium.org/213002

Expand Messages | Collapse Messages