Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issue 21285: Remove experimental ExternalSymbolCallback feature. This is not needed... (Closed)

Created:
11 years, 10 months ago by iposva
Modified:
9 years, 4 months ago
CC:
v8-dev
Visibility:
Public.

Description

Remove experimental ExternalSymbolCallback feature. This is not needed since we can now transform String objects to be external when needed. Committed: http://code.google.com/p/v8/source/detail?r=1260

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -157 lines) Patch
M include/v8.h View 2 chunks +0 lines, -31 lines 0 comments Download
M src/api.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/heap.h View 1 3 chunks +0 lines, -9 lines 0 comments Download
M src/heap.cc View 1 4 chunks +1 line, -57 lines 0 comments Download
M src/heap-inl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +0 lines, -52 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
iposva
11 years, 10 months ago (2009-02-12 06:40:48 UTC) #1
Mads Ager (chromium)
11 years, 10 months ago (2009-02-12 07:14:56 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698