Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1494)

Unified Diff: core/cross/command_buffer/effect_cb.cc

Issue 212018: Change command buffer client code to use structures.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/o3d/
Patch Set: '' Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « core/cross/command_buffer/buffer_cb.cc ('k') | core/cross/command_buffer/param_cache_cb.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: core/cross/command_buffer/effect_cb.cc
===================================================================
--- core/cross/command_buffer/effect_cb.cc (revision 26638)
+++ core/cross/command_buffer/effect_cb.cc (working copy)
@@ -92,19 +92,17 @@
ResourceID resource_id = renderer_->effect_ids().AllocateID();
CommandBufferHelper *helper = renderer_->helper();
- CommandBufferEntry args[4];
- args[0].value_uint32 = resource_id;
- args[1].value_uint32 = source_size;
- args[2].value_uint32 = renderer_->transfer_shm_id();
- args[3].value_uint32 = renderer_->allocator()->GetOffset(buffer_data);
- helper->AddCommand(command_buffer::CREATE_EFFECT, 4, args);
+ helper->CreateEffect(
+ resource_id, source_size,
+ renderer_->transfer_shm_id(),
+ renderer_->allocator()->GetOffset(buffer_data));
renderer_->allocator()->FreePendingToken(buffer_data, helper->InsertToken());
// NOTE: we're calling Finish to check the command result, to see if
// the effect has succesfully compiled.
helper->Finish();
if (renderer_->sync_interface()->GetParseError() !=
- BufferSyncInterface::PARSE_NO_ERROR) {
+ BufferSyncInterface::kParseNoError) {
O3D_ERROR(service_locator()) << "Effect failed to compile.";
renderer_->effect_ids().FreeID(resource_id);
return false;
@@ -140,9 +138,7 @@
++generation_;
if (resource_id_ != command_buffer::kInvalidResource) {
CommandBufferHelper *helper = renderer_->helper();
- CommandBufferEntry args[1];
- args[0].value_uint32 = resource_id_;
- helper->AddCommand(command_buffer::DESTROY_EFFECT, 1, args);
+ helper->DestroyEffect(resource_id_);
renderer_->effect_ids().FreeID(resource_id_);
resource_id_ = command_buffer::kInvalidResource;
}
« no previous file with comments | « core/cross/command_buffer/buffer_cb.cc ('k') | core/cross/command_buffer/param_cache_cb.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698