Change command buffer client code to use structures....

core/cross/command_buffer/effect_cb.cc

 /*
  * Copyright 2009, Google Inc.
  * All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 74 matching lines @@
   memcpy(buffer_data, vp_main.data(), vp_main.size());
   buffer_data[vp_main.size()] = 0;
   memcpy(buffer_data + vp_main.size() + 1, fp_main.data(), fp_main.size());
   buffer_data[vp_main.size() + 1 + fp_main.size()] = 0;
   memcpy(buffer_data + vp_main.size() + 1 + fp_main.size() + 1,
          source.data(), source.size());
 
   ResourceID resource_id = renderer_->effect_ids().AllocateID();
 
   CommandBufferHelper *helper = renderer_->helper();
-  CommandBufferEntry args[4];
-  args[0].value_uint32 = resource_id;
-  args[1].value_uint32 = source_size;
-  args[2].value_uint32 = renderer_->transfer_shm_id();
-  args[3].value_uint32 = renderer_->allocator()->GetOffset(buffer_data);
-  helper->AddCommand(command_buffer::CREATE_EFFECT, 4, args);
+  helper->CreateEffect(
+      resource_id, source_size,
+      renderer_->transfer_shm_id(),
+      renderer_->allocator()->GetOffset(buffer_data));
   renderer_->allocator()->FreePendingToken(buffer_data, helper->InsertToken());
 
   // NOTE: we're calling Finish to check the command result, to see if
   // the effect has succesfully compiled.
   helper->Finish();
   if (renderer_->sync_interface()->GetParseError() !=
-      BufferSyncInterface::PARSE_NO_ERROR) {
+      BufferSyncInterface::kParseNoError) {
     O3D_ERROR(service_locator()) << "Effect failed to compile.";
     renderer_->effect_ids().FreeID(resource_id);
     return false;
   }
   resource_id_ = resource_id;
   EffectHelper effect_helper(helper, renderer_->allocator(),
                              renderer_->transfer_shm_id(),
                              &renderer_->effect_param_ids());
   if (!effect_helper.CreateEffectParameters(resource_id, &param_descs_)) {
     O3D_ERROR(service_locator()) << "Failed to create effect parameters.";
@@ skipping 15 matching lines @@
   }
   set_source(source);
   return true;
 }
 
 void EffectCB::Destroy() {
   set_source("");
   ++generation_;
   if (resource_id_ != command_buffer::kInvalidResource) {
     CommandBufferHelper *helper = renderer_->helper();
-    CommandBufferEntry args[1];
-    args[0].value_uint32 = resource_id_;
-    helper->AddCommand(command_buffer::DESTROY_EFFECT, 1, args);
+    helper->DestroyEffect(resource_id_);
     renderer_->effect_ids().FreeID(resource_id_);
     resource_id_ = command_buffer::kInvalidResource;
   }
   if (param_descs_.size() > 0) {
     EffectHelper effect_helper(renderer_->helper(), renderer_->allocator(),
                                renderer_->transfer_shm_id(),
                                &renderer_->effect_param_ids());
     effect_helper.DestroyEffectParameters(param_descs_);
     param_descs_.clear();
   }
@@ skipping 99 matching lines @@
     if (CBSemanticToO3DSemantic(stream_descs_[i].semantic,
                                 stream_descs_[i].semantic_index,
                                 &semantic,
                                 &semantic_index)) {
       array->push_back(EffectStreamInfo(semantic, semantic_index));
     }
   }
 }
 
 }  // namespace o3d