Issue 212004: Implement WebKitTabToLinksPreferenceKey for the test_shell....

Issue 212004: Implement WebKitTabToLinksPreferenceKey for the test_shell.... (Closed)

Created:
11 years, 3 months ago by arv (Not doing code reviews)

Modified:
9 years, 3 months ago

Reviewers:
darin (slow to review), dglazkov

CC:
chromium-reviews_googlegroups.com, pam+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Implement WebKitTabToLinksPreferenceKey for the test_shell. BUG=21267 TEST=Run layout tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26508

Patch Set 5 : '' #

Total comments: 1

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -9 lines)			Patch
M	webkit/glue/chrome_client_impl.cc	View	1 2 3 4	1 chunk	+1 line, -5 lines	0 comments	Download
M	webkit/glue/webpreferences.h	View	1 2 3 4	2 chunks	+2 lines, -0 lines	0 comments	Download
M	webkit/glue/webpreferences.cc	View	1 2 3 4	1 chunk	+4 lines, -0 lines	0 comments	Download
M	webkit/glue/webview.h	View	1 2 3 4	1 chunk	+3 lines, -0 lines	1 comment	Download
M	webkit/glue/webview_impl.h	View	1 2 3 4	2 chunks	+6 lines, -0 lines	0 comments	Download
M	webkit/glue/webview_impl.cc	View	1 2 3 4	1 chunk	+8 lines, -0 lines	0 comments	Download
M	webkit/tools/layout_tests/test_expectations.txt	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	webkit/tools/test_shell/layout_test_controller.cc	View	1 2 3 4	1 chunk	+2 lines, -0 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell.cc	View	1 2 3 4	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

darin (slow to review)

http://codereview.chromium.org/212004/diff/5009/5012 File webkit/glue/webview.h (right): http://codereview.chromium.org/212004/diff/5009/5012#newcode252 Line 252: virtual bool GetTabsToLinks() const = 0; hmm... only ...

11 years, 3 months ago (2009-09-17 19:24:54 UTC) #2

darin (slow to review)

11 years, 3 months ago (2009-09-17 19:26:10 UTC) #3

I forgot to say "LGTM"

On Thu, Sep 17, 2009 at 12:24 PM, <darin@chromium.org> wrote:

>
> http://codereview.chromium.org/212004/diff/5009/5012
> File webkit/glue/webview.h (right):
>
> http://codereview.chromium.org/212004/diff/5009/5012#newcode252
> Line 252: virtual bool GetTabsToLinks() const = 0;
> hmm... only the setter is really needed on the interface.  you could
> also implement SetTabsToLinks by calling a method on the
> ChromeClientImpl to set a member variable of ChromeClientImpl.
>
> That said, I see that you are just following the pattern of
> Set/GetSpellingPanelVisibility and Set/GetIsTransparent.
>
> I'm OK with this change on that basis.  I might reconsider all of these
> methods once I get around to moving WebView into webkit/api/public.
>
>
> http://codereview.chromium.org/212004
>

Expand Messages | Collapse Messages