Issue 21171: Fix linking of mksnapshot

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 21171: Fix linking of mksnapshot (Closed)

Created:
11 years, 10 months ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
Christian Plesner Hansen

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Fix linking of mksnapshot Changelist http://codereview.chromium.org/20177 caused linking of mksnapshot to fail as link libraries where not specified. Updated build to link mksnapshot with pthread on Linux and Mac OS and with winmm on Windows. Committed: http://code.google.com/p/v8/source/detail?r=1241

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -2 lines)			Patch
	M	SConstruct	View		3 chunks	+25 lines, -1 line	0 comments	Download
	M	src/SConscript	View		1 chunk	+3 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

Lgtm