Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 20177: Support for building V8 with MinGW (Closed)

Created:
11 years, 10 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Support for building V8 with MinGW V8 can now be build with MinGW. It still fails the following four tests in debug mode: mjsunit/parse-int-float mjsunit/mirror-array.js mjsunit/integer-to-string.js mjsunit/regress/regress-114.js Building with MinGW has been tested with version 5.1.4 using GCC 3.4.5. In addition to supporting MinGW this change also makes it more explicit which targets needs to link with which libraries. BUG=64 Committed: http://code.google.com/p/v8/source/detail?r=1240

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -39 lines) Patch
M SConstruct View 8 chunks +57 lines, -7 lines 0 comments Download
M src/cpu-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/dtoa-config.c View 1 chunk +5 lines, -0 lines 0 comments Download
M src/globals.h View 3 chunks +9 lines, -7 lines 0 comments Download
M src/platform.h View 3 chunks +22 lines, -7 lines 0 comments Download
M src/platform-win32.cc View 1 10 chunks +76 lines, -15 lines 0 comments Download
M tools/visual_studio/d8.vcproj View 3 chunks +3 lines, -1 line 0 comments Download
M tools/visual_studio/v8_cctest.vcproj View 3 chunks +3 lines, -1 line 0 comments Download
M tools/visual_studio/v8_mksnapshot.vcproj View 2 chunks +2 lines, -0 lines 0 comments Download
M tools/visual_studio/v8_process_sample.vcproj View 2 chunks +2 lines, -0 lines 0 comments Download
M tools/visual_studio/v8_shell_sample.vcproj View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Thygesen Gjesse
11 years, 10 months ago (2009-02-09 14:19:25 UTC) #1
Christian Plesner Hansen
Lgtm http://codereview.chromium.org/20177/diff/1/8 File src/platform-win32.cc (right): http://codereview.chromium.org/20177/diff/1/8#newcode170 Line 170: int localtime_s(tm* _tm, const time_t* time) { ...
11 years, 10 months ago (2009-02-09 14:39:42 UTC) #2
Søren Thygesen Gjesse
11 years, 10 months ago (2009-02-09 15:05:22 UTC) #3
http://codereview.chromium.org/20177/diff/1/8
File src/platform-win32.cc (right):

http://codereview.chromium.org/20177/diff/1/8#newcode170
Line 170: int localtime_s(tm* _tm, const time_t* time) {
On 2009/02/09 14:39:42, Christian Plesner Hansen wrote:
> Underscore tm?

Changed to out_tm.

http://codereview.chromium.org/20177/diff/1/8#newcode171
Line 171: tm * posix_local_time_struct = localtime(time);
On 2009/02/09 14:39:42, Christian Plesner Hansen wrote:
> Space before *?

Not any more.

Powered by Google App Engine
This is Rietveld 408576698