Added texture update test.

Added texture update test.

[piman, 2010-05-21 17:20:11]

http://codereview.chromium.org/2115012/diff/1/3
File client/deps/glbench/src/bench.cc (right):

http://codereview.chromium.org/2115012/diff/1/3#newcode13
client/deps/glbench/src/bench.cc:13: return ~0;
this case should then be checked in Bench so that the sample is discarded, etc.

http://codereview.chromium.org/2115012/diff/1/5
File client/deps/glbench/src/textureupdatetest.cc (right):

http://codereview.chromium.org/2115012/diff/1/5#newcode15
client/deps/glbench/src/textureupdatetest.cc:15: const int NUMBER_OF_TEXTURES =
8;
kNumberOfTextures

also, mark static.

http://codereview.chromium.org/2115012/diff/1/5#newcode38
client/deps/glbench/src/textureupdatetest.cc:38: static const char
*vertex_shader =
kVertexShader, star on the left

http://codereview.chromium.org/2115012/diff/1/5#newcode47
client/deps/glbench/src/textureupdatetest.cc:47: static const char
*fragment_shader =
kFragmentShader, star on the left.

http://codereview.chromium.org/2115012/diff/1/5#newcode65
client/deps/glbench/src/textureupdatetest.cc:65: pixels[i].reset(new char[width_
* height_]);
can we do all the allocations/glTexImage2D in Run() ? new can take arbitrary
long time, and glGetError is likely to do a glFinish().

http://codereview.chromium.org/2115012/diff/1/5#newcode72
client/deps/glbench/src/textureupdatetest.cc:72: pixels[i %
NUMBER_OF_TEXTURES].get());
I'm curious about testing glTexSubImage2D as well, when setting the whole
texture.

[Alexey Marinichev, 2010-05-21 20:21:41]

Should I initialize pixels_ or its default constructor is fine?

http://codereview.chromium.org/2115012/diff/1/3
File client/deps/glbench/src/bench.cc (right):

http://codereview.chromium.org/2115012/diff/1/3#newcode13
client/deps/glbench/src/bench.cc:13: return ~0;
On 2010/05/21 17:20:11, piman wrote:
> this case should then be checked in Bench so that the sample is discarded,
etc.

This code is a leftover, it lives in testbase.cc now.

http://codereview.chromium.org/2115012/diff/1/5
File client/deps/glbench/src/textureupdatetest.cc (right):

http://codereview.chromium.org/2115012/diff/1/5#newcode15
client/deps/glbench/src/textureupdatetest.cc:15: const int NUMBER_OF_TEXTURES =
8;
On 2010/05/21 17:20:11, piman wrote:
> kNumberOfTextures
> 
> also, mark static.

Done.

http://codereview.chromium.org/2115012/diff/1/5#newcode38
client/deps/glbench/src/textureupdatetest.cc:38: static const char
*vertex_shader =
On 2010/05/21 17:20:11, piman wrote:
> kVertexShader, star on the left

Done.

http://codereview.chromium.org/2115012/diff/1/5#newcode47
client/deps/glbench/src/textureupdatetest.cc:47: static const char
*fragment_shader =
On 2010/05/21 17:20:11, piman wrote:
> kFragmentShader, star on the left.

Done.

http://codereview.chromium.org/2115012/diff/1/5#newcode65
client/deps/glbench/src/textureupdatetest.cc:65: pixels[i].reset(new char[width_
* height_]);
On 2010/05/21 17:20:11, piman wrote:
> can we do all the allocations/glTexImage2D in Run() ? new can take arbitrary
> long time, and glGetError is likely to do a glFinish().

Done.

[piman, 2010-05-21 21:27:48]

LGTM

[piman, 2010-05-21 22:15:02]

http://codereview.chromium.org/2115012/diff/7003/12006
File client/deps/glbench/src/textureupdatetest.cc (right):

http://codereview.chromium.org/2115012/diff/7003/12006#newcode24
client/deps/glbench/src/textureupdatetest.cc:24: typedef enum {
In C++ you usually do:
enum UpdateFlavor {
  TEX_IMAGE,
  TEX_SUBIMAGE
};