Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Issue 211033: Automated ui test porting + cleanup:... (Closed)

Created:
11 years, 3 months ago by Evan Stade
Modified:
9 years, 6 months ago
Reviewers:
huanr
CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google), Paweł Hajdan Jr.
Visibility:
Public.

Description

Automated ui test porting + cleanup: - Change POINTs to gfx::Point - Get rid of 2 unused automation messages (the messages themselves are staying for now so we don't mess with the reference build) -- add new automation messages to replace GetWindowHWND, which is not portable - re-enable automated_ui_test_interactive_test (it seems to have been dropped when we converted to gyp) - compile additional tests on linux (they don't pass, so they are disabled) - stub out linux tab dragging automation implementation (browser side) - delete various cruft BUG=19758

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : fix compile (hopefully) #

Total comments: 2

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : all green\! #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+272 lines, -351 lines) Patch
M chrome/browser/automation/automation_provider.h View 1 2 3 4 4 chunks +4 lines, -11 lines 0 comments Download
M chrome/browser/automation/automation_provider.cc View 1 2 3 4 3 chunks +5 lines, -34 lines 0 comments Download
M chrome/browser/automation/automation_provider_gtk.cc View 1 2 3 4 5 3 chunks +31 lines, -1 line 0 comments Download
M chrome/browser/automation/automation_provider_mac.mm View 4 5 3 chunks +28 lines, -0 lines 0 comments Download
M chrome/browser/automation/automation_provider_win.cc View 1 2 3 4 5 6 8 chunks +41 lines, -42 lines 0 comments Download
M chrome/browser/browser_uitest.cc View 4 2 chunks +2 lines, -15 lines 0 comments Download
M chrome/browser/views/tabs/tab_dragging_test.cc View 4 chunks +17 lines, -24 lines 0 comments Download
M chrome/chrome.gyp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/pref_service_uitest.cc View 4 5 6 2 chunks +10 lines, -12 lines 0 comments Download
M chrome/test/automated_ui_tests/automated_ui_test_base.cc View 1 2 3 7 chunks +14 lines, -17 lines 0 comments Download
M chrome/test/automated_ui_tests/automated_ui_test_interactive_test.cc View 1 2 3 4 chunks +13 lines, -7 lines 0 comments Download
M chrome/test/automated_ui_tests/automated_ui_tests.cc View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/test/automation/automation_messages.h View 1 2 3 1 chunk +0 lines, -63 lines 0 comments Download
M chrome/test/automation/automation_messages_internal.h View 1 2 3 4 4 chunks +45 lines, -17 lines 0 comments Download
M chrome/test/automation/automation_proxy_uitest.cc View 1 2 3 4 chunks +8 lines, -19 lines 0 comments Download
M chrome/test/automation/browser_proxy.h View 1 2 3 4 4 chunks +9 lines, -17 lines 2 comments Download
M chrome/test/automation/browser_proxy.cc View 1 2 3 4 6 chunks +17 lines, -23 lines 0 comments Download
M chrome/test/automation/tab_proxy.h View 1 2 3 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/test/automation/tab_proxy.cc View 1 2 3 1 chunk +0 lines, -18 lines 0 comments Download
M chrome/test/automation/window_proxy.h View 3 4 3 chunks +7 lines, -8 lines 0 comments Download
M chrome/test/automation/window_proxy.cc View 3 4 3 chunks +20 lines, -13 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Evan Stade
11 years, 3 months ago (2009-09-18 21:16:20 UTC) #1
huanr
I thought GetHWND is used by several tests including browser_uitest. It is not the case ...
11 years, 3 months ago (2009-09-20 23:34:59 UTC) #2
Evan Stade
you are right, some tests do need it. I changed those calls to GetHWND to ...
11 years, 3 months ago (2009-09-21 23:22:52 UTC) #3
Evan Stade
got all green trybot results, take another look?
11 years, 3 months ago (2009-09-22 02:05:54 UTC) #4
huanr
LGTM http://codereview.chromium.org/211033/diff/4024/4028 File chrome/test/automation/browser_proxy.h (right): http://codereview.chromium.org/211033/diff/4024/4028#newcode198 Line 198: // Terminates the browser session. Would be ...
11 years, 3 months ago (2009-09-22 03:42:24 UTC) #5
Evan Stade
11 years, 3 months ago (2009-09-22 19:42:01 UTC) #6
http://codereview.chromium.org/211033/diff/4024/4028
File chrome/test/automation/browser_proxy.h (right):

http://codereview.chromium.org/211033/diff/4024/4028#newcode198
Line 198: // Terminates the browser session.
On 2009/09/22 03:42:24, huanr wrote:
> Would be helpful if adding comments saying this happens due to the user shuts
> down the machine or logs off. We already have a function
UITest::CloseBrowser().

Done.

Powered by Google App Engine
This is Rietveld 408576698