Automated ui test porting + cleanup:...

chrome/test/automation/browser_proxy.h

Index: chrome/test/automation/browser_proxy.h
===================================================================
--- chrome/test/automation/browser_proxy.h	(revision 26702)
+++ chrome/test/automation/browser_proxy.h	(working copy)
@@ -21,6 +21,7 @@
 class AutocompleteEditProxy;
 
 namespace gfx {
+  class Point;
   class Rect;
 }
 
@@ -122,22 +123,21 @@
   // desktop.
   bool ApplyAccelerator(int id);
 
-#if defined(OS_WIN)
-  // TODO(port): Use portable replacement for POINT.
-
   // Performs a drag operation between the start and end points (both defined
   // in window coordinates).  |flags| specifies which buttons are pressed for
   // the drag, as defined in chrome/views/event.h.
-  virtual bool SimulateDrag(const POINT& start, const POINT& end, int flags,
+  virtual bool SimulateDrag(const gfx::Point& start,
+                            const gfx::Point& end,
+                            int flags,
                             bool press_escape_en_route);
 
   // Like SimulateDrag, but returns false if response is not received before
   // the specified timeout.
-  virtual bool SimulateDragWithTimeout(const POINT& start, const POINT& end,
+  virtual bool SimulateDragWithTimeout(const gfx::Point& start,
+                                       const gfx::Point& end,
                                        int flags, uint32 timeout_ms,
                                        bool* is_timeout,
                                        bool press_escape_en_route);
-#endif  // defined(OS_WIN)
 
   // Block the thread until the tab count is |count|.
   // |wait_timeout| is the timeout, in milliseconds, for waiting.
@@ -161,17 +161,6 @@
   // will be false. Returns false on failure.
   bool IsFindWindowFullyVisible(bool* is_visible);
 
-#if defined(OS_WIN)
-  // TODO(port): Use portable equivalent of HWND.
-
-  // Gets the outermost HWND that corresponds to the given browser.
-  // Returns true if the call was successful.
-  // Note that ideally this should go and the version of WindowProxy should be
-  // used instead.  We have to keep it for start_up_tests that test against a
-  // reference build.
-  bool GetHWND(HWND* handle) const;
-#endif  // defined(OS_WIN)
-
   // Run the specified command in the browser (see browser_commands.cc for the
   // list of supported commands).  Returns true if the command was successfully
   // dispatched, false otherwise.
@@ -206,6 +195,9 @@
   // Sets the boolean value of the specified preference.
   bool SetBooleanPreference(const std::wstring& name, bool value);
 
+  // Terminates the browser session.

[huanr, 2009/09/22 03:42:24]

Would be helpful if adding comments saying this happens due to the user shuts
down the machine or logs off. We already have a function UITest::CloseBrowser().

[Evan Stade, 2009/09/22 19:42:01]

Done.

+  bool TerminateSession();
+
  protected:
   virtual ~BrowserProxy() {}
  private: