swarmbucket: non-string properties

swarmbucket: non-string properties

Currently swarmbucket supports only string properties, e.g. "a:b" means
a property value is a string "b", "x:True" means x property value is a
string "True".

Add properties_j config field that interprets substring after colon as
JSON-encoded value, for example "a:1" and "b:true" means that properties
a and b have values 1 and True repspectively. Fields properties and
properties_j can be used together, but cannot set a vaue for the same
property:

  properties: "a:b"
  properties: "x:1"

Note that properties_j does not deprecate properties because it is very
inconvenient and verbose to escape quotes in text proto:
properties_j: "a:\"b\""

Why not property message, like {name: "a"; int: 3}? Because message
{name: "a"; int:0} may be indistinguishable from {name:"a"; b: false}
because both have default field values.

R=vadimsh@chromium.org
BUG=

Committed: https://chromium.googlesource.com/infra/infra/+/ca95ab8343c66e8842f6bb1c03d070205a2d19c6

[nodir, 2016-06-28 00:04:12]

PTAL

[Vadim Sh., 2016-06-28 00:10:35]

lgtm *shrug*

https://codereview.chromium.org/2106633002/diff/20001/appengine/cr-buildbucke...
File appengine/cr-buildbucket/proto/project_config.proto (right):

https://codereview.chromium.org/2106633002/diff/20001/appengine/cr-buildbucke...
appengine/cr-buildbucket/proto/project_config.proto:44: // Same as properties,
but the value must valid JSON. For example
is it allowed to have "a:{\"b\":\"c\"}"?

https://codereview.chromium.org/2106633002/diff/20001/appengine/cr-buildbucke...
File appengine/cr-buildbucket/swarming/test/swarming_test.py (right):

https://codereview.chromium.org/2106633002/diff/20001/appengine/cr-buildbucke...
appengine/cr-buildbucket/swarming/test/swarming_test.py:62: self.maxDiff = 9999
you can also use None (means "unlimited")

[nodir, 2016-06-28 00:42:31]

The CQ bit was checked by nodir@chromium.org

[nodir, 2016-06-28 00:42:32]

The patchset sent to the CQ was uploaded after l-g-t-m from vadimsh@chromium.org
Link to the patchset: https://codereview.chromium.org/2106633002/#ps40001
(title: "remove 9999")

[commit-bot: I haz the power, 2016-06-28 00:42:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nodir, 2016-06-28 00:42:38]

https://codereview.chromium.org/2106633002/diff/20001/appengine/cr-buildbucke...
File appengine/cr-buildbucket/proto/project_config.proto (right):

https://codereview.chromium.org/2106633002/diff/20001/appengine/cr-buildbucke...
appengine/cr-buildbucket/proto/project_config.proto:44: // Same as properties,
but the value must valid JSON. For example
On 2016/06/28 00:10:35, Vadim Sh. wrote:
> is it allowed to have "a:{\"b\":\"c\"}"?

yes, not prohibited, but not encouraged either (by making it inconvenient)

https://codereview.chromium.org/2106633002/diff/20001/appengine/cr-buildbucke...
File appengine/cr-buildbucket/swarming/test/swarming_test.py (right):

https://codereview.chromium.org/2106633002/diff/20001/appengine/cr-buildbucke...
appengine/cr-buildbucket/swarming/test/swarming_test.py:62: self.maxDiff = 9999
On 2016/06/28 00:10:35, Vadim Sh. wrote:
> you can also use None (means "unlimited")

i forgot to remove this

[commit-bot: I haz the power, 2016-06-28 01:04:56]

Description was changed from

==========
swarmbucket: non-string properties

Currently swarmbucket supports only string properties, e.g. "a:b" means
a property value is a string "b", "x:True" means x property value is a
string "True".

Add properties_j config field that interprets substring after colon as
JSON-encoded value, for example "a:1" and "b:true" means that properties
a and b have values 1 and True repspectively. Fields properties and
properties_j can be used together, but cannot set a vaue for the same
property:

  properties: "a:b"
  properties: "x:1"

Note that properties_j does not deprecate properties because it is very
inconvenient and verbose to escape quotes in text proto:
properties_j: "a:\"b\""

Why not property message, like {name: "a"; int: 3}? Because message
{name: "a"; int:0} may be indistinguishable from {name:"a"; b: false}
because both have default field values.

R=vadimsh@chromium.org
BUG=
==========

to

==========
swarmbucket: non-string properties

Currently swarmbucket supports only string properties, e.g. "a:b" means
a property value is a string "b", "x:True" means x property value is a
string "True".

Add properties_j config field that interprets substring after colon as
JSON-encoded value, for example "a:1" and "b:true" means that properties
a and b have values 1 and True repspectively. Fields properties and
properties_j can be used together, but cannot set a vaue for the same
property:

  properties: "a:b"
  properties: "x:1"

Note that properties_j does not deprecate properties because it is very
inconvenient and verbose to escape quotes in text proto:
properties_j: "a:\"b\""

Why not property message, like {name: "a"; int: 3}? Because message
{name: "a"; int:0} may be indistinguishable from {name:"a"; b: false}
because both have default field values.

R=vadimsh@chromium.org
BUG=

Committed:
https://chromium.googlesource.com/infra/infra/+/ca95ab8343c66e8842f6bb1c03d07...
==========

[commit-bot: I haz the power, 2016-06-28 01:04:57]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/infra/infra/+/ca95ab8343c66e8842f6bb1c03d07...