Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2333)

Unified Diff: appengine/cr-buildbucket/proto/project_config.proto

Issue 2106633002: swarmbucket: non-string properties (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: remove 9999 Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | appengine/cr-buildbucket/proto/project_config_pb2.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/cr-buildbucket/proto/project_config.proto
diff --git a/appengine/cr-buildbucket/proto/project_config.proto b/appengine/cr-buildbucket/proto/project_config.proto
index 0edc1849d315274899765781e92c558b4cfc67e0..60ae4d523b48ae16a05957ccac7182d8a0f0b27b 100644
--- a/appengine/cr-buildbucket/proto/project_config.proto
+++ b/appengine/cr-buildbucket/proto/project_config.proto
@@ -37,7 +37,17 @@ message Swarming {
optional string name = 2;
// colon-separated build properties to set.
// A property can be overriden by "properties" build parameter.
+ //
+ // Use this field for string properties and use properties_j for other
+ // types.
repeated string properties = 3;
+ // Same as properties, but the value must valid JSON. For example
+ // properties_j: "a:1"
+ // means property a is a number 1, not string "1".
+ //
+ // Fields properties and properties_j can be used together, but cannot both
+ // specify values for same property.
+ repeated string properties_j = 4;
}
message Builder {
« no previous file with comments | « no previous file | appengine/cr-buildbucket/proto/project_config_pb2.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698