Install metrics files from the ebuild.

Install metrics files from the ebuild.

Also install the metrics library mock header file to make it easier to
add unit tests in metrics clients.

[petkov, 2010-05-13 19:14:16]

Related CL: http://codereview.chromium.org/2087002

[Mandeep Singh Baines, 2010-05-13 20:25:26]

petkov@chromium.org (petkov@chromium.org) wrote:
> Reviewers: kmixter1, sosa,
>
> Message:
> Related CL: http://codereview.chromium.org/2087002
>
>
> Description:
> Install metrics files from the ebuild.
>
> Also install the metrics library mock header file to make it easier to
> add unit tests in metrics clients.
>
> Please review this at http://codereview.chromium.org/2104001/show
>
> SVN Base: ssh://git@chromiumos-git/chromiumos-overlay.git
>
> Affected files:
>   A + chromeos-base/crash-reporter/crash-reporter-9999-r2.ebuild
>   A + chromeos-base/metrics/metrics-0.0.1-r9.ebuild
>   M chromeos-base/metrics/metrics-0.0.1.ebuild
>
>
> Index: chromeos-base/crash-reporter/crash-reporter-9999-r2.ebuild
> diff --git a/chromeos-base/crash-reporter/crash-reporter-9999-r1.ebuild  
> b/chromeos-base/crash-reporter/crash-reporter-9999-r2.ebuild
> similarity index 100%
> rename from chromeos-base/crash-reporter/crash-reporter-9999-r1.ebuild
> rename to chromeos-base/crash-reporter/crash-reporter-9999-r2.ebuild
> Index: chromeos-base/metrics/metrics-0.0.1-r9.ebuild
> diff --git a/chromeos-base/metrics/metrics-0.0.1-r8.ebuild  
> b/chromeos-base/metrics/metrics-0.0.1-r9.ebuild
> similarity index 100%
> rename from chromeos-base/metrics/metrics-0.0.1-r8.ebuild
> rename to chromeos-base/metrics/metrics-0.0.1-r9.ebuild
> Index: chromeos-base/metrics/metrics-0.0.1.ebuild
> diff --git a/chromeos-base/metrics/metrics-0.0.1.ebuild  
> b/chromeos-base/metrics/metrics-0.0.1.ebuild
> index  
>
4635c5cd882ddc1d16579077bec4e8d8511cbfc3..2af34be6714f8f6c37f6e46e3c23c4012dc7d695

> 100644
> --- a/chromeos-base/metrics/metrics-0.0.1.ebuild
> +++ b/chromeos-base/metrics/metrics-0.0.1.ebuild
> @@ -50,10 +50,21 @@ src_test() {
>  }
>
>  src_install() {
> -	dodir /usr/bin
> -	dodir /usr/include
> -	dodir /usr/lib
> -	dodir /usr/sbin
> -	emake DESTDIR="${D}" install || die "metrics install failed."
> -	chmod 0555 "${D}/usr/sbin/omaha_tracker.sh"
> +	exeinto "/usr/bin"

not neccessary /usb/bin is the default

> +	doexe "${S}/metrics_client"
> +	doexe "${S}/metrics_daemon"

doexe is for executable shell scripts
dobin is for binaries

http://devmanual.gentoo.org/ebuild-writing/functions/src_install/index.html

> +	doexe "${S}/syslog_parser.sh"
> +
> +	exeinto "/usr/sbin"
> +	doexe "${S}/omaha_tracker.sh"
> +

dosbin

> +	exeinto "/usr/lib"
> +	doexe "${S}/libmetrics.so"
> +

dolib

http://devmanual.gentoo.org/function-reference/install-functions/index.html

> +	insinto "/usr/lib"
> +	doins "${S}/libmetrics.a"
> +

dolib

> +	insinto "/usr/include/metrics"
> +	doins "${S}/metrics_library.h"
> +	doins "${S}/metrics_library_mock.h"
>  }
>
>

[petkov, 2010-05-13 20:49:02]

Thanks for the feedback, CL patched with simplified installation steps. PTAL.

[petkov, 2010-05-13 21:16:26]

Finalized the install steps. PTAL. Thanks!

[sosa, 2010-05-13 21:18:02]

Does look nicer with msb's changes.  LGTM

[Mandeep Singh Baines, 2010-05-13 21:31:08]

LGTM. Thanks!