Issue 2087002: Per kmixter's suggestion, install metrics headers under /usr/include/metrics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2087002: Per kmixter's suggestion, install metrics headers under /usr/include/metrics. (Closed)

Created:
10 years, 7 months ago by petkov

Modified:
9 years, 7 months ago

Reviewers:
kmixter1, sosa

CC:
chromium-os-reviews_chromium.org, petkov, Luigi Semenzato, sosa

Base URL:
ssh://git@chromiumos-git/chromeos

Visibility:
Public.

Description

Per kmixter's suggestion, install metrics headers under /usr/include/metrics. Also, move file installation to the metrics ebuild.

Patch Set 1 #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -12 lines)			Patch
M	src/platform/crash/crash_reporter.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/platform/crash/user_collector.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/platform/metrics/Makefile	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	src/platform/metrics/README	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sosa

lgtm. Yeah, /usr/include is a good idea. It'll also save us some (very few) bytes ...

10 years, 7 months ago (2010-05-13 21:09:48 UTC) #2

kmixter1

10 years, 7 months ago (2010-05-15 00:56:07 UTC) #3

LGTM

On Thu, May 13, 2010 at 2:09 PM,  <sosa@chromium.org> wrote:
> lgtm.  Yeah, /usr/include is a good idea.  It'll also save us some (very
> few)
> bytes on the resulting image.  Hooray for helping with one of our
> objectives.
>
> http://codereview.chromium.org/2087002/show
>

Expand Messages | Collapse Messages