Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 21039: Revert my change to get the tree green. Not sure why the tests became flaky.... (Closed)

Created:
11 years, 10 months ago by jam
Modified:
9 years, 7 months ago
Reviewers:
Matt Perry
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Revert my change to get the tree green. Not sure why the tests became flaky. I'll try to check them in again but in smaller chunks tomorrow. TBR=mpcomplete Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=9132

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1796 lines, -1534 lines) Patch
M chrome/app/chrome_main_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/automation/automation_provider.cc View 2 chunks +3 lines, -8 lines 0 comments Download
M chrome/browser/browser_accessibility.h View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/browser_accessibility.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/browser_accessibility_manager.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/browser_accessibility_manager.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/printing/print_view_manager.h View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/printing/print_view_manager.cc View 3 chunks +21 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/render_view_host.h View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/renderer_host/render_view_host.cc View 3 chunks +18 lines, -5 lines 0 comments Download
M chrome/browser/renderer_host/render_view_host_delegate.h View 3 chunks +2 lines, -10 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view.h View 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_win.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/renderer_host/test_render_view_host.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resource_message_filter.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resource_message_filter.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ssl/ssl_uitest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/interstitial_page.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/ipc_status_view.cc View 4 chunks +16 lines, -17 lines 0 comments Download
M chrome/browser/tab_contents/web_contents.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome.xcodeproj/project.pbxproj View 4 chunks +4 lines, -0 lines 0 comments Download
M chrome/common/common.scons View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/common/common.vcproj View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/common/ipc_fuzzing_tests.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/common/ipc_logging.h View 5 chunks +4 lines, -13 lines 0 comments Download
M chrome/common/ipc_logging.cc View 3 chunks +15 lines, -15 lines 0 comments Download
M chrome/common/ipc_message_macros.h View 9 chunks +20 lines, -34 lines 0 comments Download
M chrome/common/ipc_message_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/ipc_message_utils.h View 62 chunks +191 lines, -256 lines 0 comments Download
M chrome/common/ipc_message_utils.cc View 10 chunks +17 lines, -12 lines 0 comments Download
M chrome/common/ipc_sync_channel_unittest.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/common/ipc_sync_message_unittest.h View 1 chunk +1 line, -10 lines 0 comments Download
M chrome/common/ipc_sync_message_unittest.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M chrome/common/plugin_messages.h View 13 chunks +183 lines, -169 lines 0 comments Download
M chrome/common/plugin_messages_internal.h View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/render_messages.h View 44 chunks +669 lines, -627 lines 0 comments Download
M chrome/common/render_messages_internal.h View 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/common/resource_bundle.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/common/resource_dispatcher_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/security_filter_peer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/temp_scaffolding_stubs.h View 5 chunks +3 lines, -6 lines 0 comments Download
M chrome/plugin/chrome_plugin_host.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/plugin/webplugin_delegate_stub.h View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/renderer/render_view.cc View 1 chunk +6 lines, -1 line 0 comments Download
M chrome/renderer/render_widget.h View 2 chunks +20 lines, -6 lines 0 comments Download
M chrome/renderer/render_widget.cc View 2 chunks +0 lines, -21 lines 0 comments Download
M chrome/renderer/webplugin_delegate_proxy.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/renderer/webplugin_delegate_proxy.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/automation/autocomplete_edit_proxy.h View 3 chunks +5 lines, -2 lines 0 comments Download
M chrome/test/automation/automation_messages.h View 2 chunks +20 lines, -3 lines 0 comments Download
M chrome/test/automation/automation_messages_internal.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/test/automation/automation_proxy.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/test/automation/tab_proxy.cc View 39 chunks +490 lines, -240 lines 0 comments Download
M chrome/test/unit/unit_tests.scons View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/unit/unittests.vcproj View 1 chunk +4 lines, -0 lines 0 comments Download
M webkit/glue/glue_accessibility.h View 1 chunk +1 line, -3 lines 0 comments Download
M webkit/glue/glue_accessibility.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
11 years, 10 months ago (2009-02-04 08:58:01 UTC) #1
Matt Perry
11 years, 10 months ago (2009-02-04 18:45:41 UTC) #2 
ok

Powered by Google App Engine
This is Rietveld 408576698