chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc - Issue 21039: Revert my change to get the tree green. Not sure why the tests became flaky....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc

Issue 21039: Revert my change to get the tree green. Not sure why the tests became flaky.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 11 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/renderer_host/render_widget_host_view_win.cc ('k') | chrome/browser/renderer_host/test_render_view_host.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc

===================================================================

--- chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc (revision 9131)

+++ chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc (working copy)

@@ -173,11 +173,11 @@

void* iter = NULL;

int request_id;

- ASSERT_TRUE(ReadParam(&messages[1], &iter, &request_id));

+ ASSERT_TRUE(IPC::ReadParam(&messages[1], &iter, &request_id));

base::SharedMemoryHandle shm_handle;

- ASSERT_TRUE(ReadParam(&messages[1], &iter, &shm_handle));

+ ASSERT_TRUE(IPC::ReadParam(&messages[1], &iter, &shm_handle));

int data_len;

- ASSERT_TRUE(ReadParam(&messages[1], &iter, &data_len));

+ ASSERT_TRUE(IPC::ReadParam(&messages[1], &iter, &data_len));

ASSERT_EQ(reference_data.size(), data_len);

base::SharedMemory shared_mem(shm_handle, true); // read only