Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 21013: Use Handle version of AddKeysFromJSArray when building line endingd array. (Closed)

Created:
11 years, 10 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Use Handle version of AddKeysFromJSArray when building line endings array. Committed: http://code.google.com/p/v8/source/detail?r=1218

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M src/handles.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/objects.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Thygesen Gjesse
11 years, 10 months ago (2009-02-03 12:58:54 UTC) #1
Mads Ager (chromium)
LGTM
11 years, 10 months ago (2009-02-03 12:59:49 UTC) #2
Dean McNamee
11 years, 10 months ago (2009-02-03 13:00:16 UTC) #3
On 2009/02/03 12:59:49, Mads Ager wrote:
> LGTM

Typo in description.

Powered by Google App Engine
This is Rietveld 408576698