media/filters/video_renderer_base.h - Issue 2101022: refactoring decoder interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/filters/video_renderer_base.h

Issue 2101022: refactoring decoder interface (Closed)

Patch Set: q Created 10 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/filters/video_renderer_base.h

diff --git a/media/filters/video_renderer_base.h b/media/filters/video_renderer_base.h

index 24e914d40e1914cd4c2dfe32a3dd0ab9357b33b3..f66d1cdba538cf21e7aa03a0358e69e8661778bc 100644

--- a/media/filters/video_renderer_base.h

+++ b/media/filters/video_renderer_base.h

@@ -82,8 +82,9 @@ class VideoRendererBase : public VideoRenderer,

virtual void OnFrameAvailable() = 0;

private:

- // Read complete callback from video decoder and decrements |pending_reads_|.

- void OnReadComplete(VideoFrame* frame);

+ // Callback from video decoder to deliver decoded video frames and decrements

+ // |pending_reads_|.

+ void OnFillBufferDone(scoped_refptr<VideoFrame> frame);

// Helper method that schedules an asynchronous read from the decoder and

// increments |pending_reads_|.

« no previous file with comments | « media/filters/decoder_base_unittest.cc ('k') | media/filters/video_renderer_base.cc » ('j') | no next file with comments »