refactoring decoder interface

media/filters/video_renderer_base.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // VideoRendererBase creates its own thread for the sole purpose of timing frame
 // presentation.  It handles reading from the decoder and stores the results in
 // a queue of decoded frames, calling OnFrameAvailable() on subclasses to notify
 // when a frame is ready to display.
 //
 // The media filter methods Initialize(), Stop(), SetPlaybackRate() and Seek()
@@ skipping 64 matching lines @@
   // Implementors should avoid doing any sort of heavy work in this method and
   // instead post a task to a common/worker thread to handle rendering.  Slowing
   // down the video thread may result in losing synchronization with audio.
   //
   // IMPORTANT: This method is called on the video renderer thread, which is
   // different from the thread OnInitialize(), OnStop(), and the rest of the
   // class executes on.
   virtual void OnFrameAvailable() = 0;
 
  private:
-  // Read complete callback from video decoder and decrements |pending_reads_|.
-  void OnReadComplete(VideoFrame* frame);
+  // Callback from video decoder to deliver decoded video frames and decrements
+  // |pending_reads_|.
+  void OnFillBufferDone(scoped_refptr<VideoFrame> frame);
 
   // Helper method that schedules an asynchronous read from the decoder and
   // increments |pending_reads_|.
   //
   // Safe to call from any thread.
   void ScheduleRead_Locked();
 
   // Calculates the duration to sleep for based on |current_frame_|'s timestamp,
   // the next frame timestamp (may be NULL), and the provided playback rate.
   //
@@ skipping 54 matching lines @@
   // Filter callbacks.
   scoped_ptr<FilterCallback> pause_callback_;
   scoped_ptr<FilterCallback> seek_callback_;
 
   DISALLOW_COPY_AND_ASSIGN(VideoRendererBase);
 };
 
 }  // namespace media
 
 #endif  // MEDIA_FILTERS_VIDEO_RENDERER_BASE_H_