Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issue 210011: [Mac] Disable autoresizing of subviews when going into and out of fullscreen... (Closed)

Created:
11 years, 3 months ago by rohitrao (ping after 24h)
Modified:
9 years, 7 months ago
Reviewers:
John Grabowski
CC:
chromium-reviews_googlegroups.com, John Grabowski, pam+watch_chromium.org, Ben Goodger (Google)
Visibility:
Public.

Description

[Mac] Disable autoresizing of subviews when going into and out of fullscreen mode. This will prevent spurious renderer resizes and reduce flicker. BUG=http://crbug.com/21666 TEST=Layout of www.google.com should not be messed up after exiting fullscreen mode. http://src.chromium.org/viewvc/chrome?view=rev&revision=26566

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M chrome/browser/cocoa/browser_window_controller.mm View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rohitrao (ping after 24h)
What do you think of this change? The problem is that when we move the ...
11 years, 3 months ago (2009-09-17 19:50:27 UTC) #1
John Grabowski
I think it sounds like a great idea. LGTM BTW, let me know if you ...
11 years, 3 months ago (2009-09-17 19:54:10 UTC) #2
rohitrao (ping after 24h)
11 years, 3 months ago (2009-09-17 19:57:32 UTC) #3
Will do.  We haven't hit that point yet, but a few more bugfixes might
put us closer.

On Thu, Sep 17, 2009 at 3:54 PM,  <jrg@chromium.org> wrote:
> I think it sounds like a great idea.
> LGTM
>
> BTW, let me know if you think we cross a threshold here; e.g. instead of
> using a
> distinct fullscreen window, you think we should use some other mechanism
> which
> might be less messy.
>
>
>
> http://codereview.chromium.org/210011
>

Powered by Google App Engine
This is Rietveld 408576698